Closed Bug 1239314 Opened 5 years ago Closed 5 years ago

Consider turning off incremental marking validation

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jonco, Assigned: terrence)

References

Details

Attachments

(1 file)

nical says that GC takes 25% of time in debug reftests, and could be a big factor in the number of test timeouts.

Incremental marking validation is something that happens in all debug GCs, but hasn't caught any bugs in as long as I can remember.

What do you think about turning this off by default and adding a zeal mode to enable it if we do want to run it?

I suppose we should measure how much this speeds up reftests first.
Flags: needinfo?(terrence)
This number comes from the first five to ten minutesof the reftest suite with a local debug build on two of my laptops. I'm not sure how much that is on actual try runs but it's worth investigating. On a very beefy desktop the same GC symbols are still getting the biggest scores although they tend to have lower percentages.
I strongly agree. Let's recycle mode 11.
Assignee: nobody → terrence
Status: NEW → ASSIGNED
Flags: needinfo?(terrence)
Attachment #8707594 - Flags: review?(jcoppeard)
Comment on attachment 8707594 [details] [diff] [review]
make_marking_validation_a_zeal_mode-v0.diff

Review of attachment 8707594 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: js/src/builtin/TestingFunctions.cpp
@@ +788,5 @@
>          ReportUsageError(cx, callee, "Wrong number of arguments");
>          return false;
>      }
>  
> +    JS_SetGCZeal(cx, 11, 0);

This needs to enable / disable validation based on the first argument.
Attachment #8707594 - Flags: review?(jcoppeard) → review+
Blocks: 1241934
https://hg.mozilla.org/mozilla-central/rev/a048c55e1906
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.