Closed
Bug 1239314
Opened 7 years ago
Closed 6 years ago
Consider turning off incremental marking validation
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jonco, Assigned: terrence)
References
Details
Attachments
(1 file)
6.92 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
nical says that GC takes 25% of time in debug reftests, and could be a big factor in the number of test timeouts. Incremental marking validation is something that happens in all debug GCs, but hasn't caught any bugs in as long as I can remember. What do you think about turning this off by default and adding a zeal mode to enable it if we do want to run it? I suppose we should measure how much this speeds up reftests first.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(terrence)
Comment 1•7 years ago
|
||
This number comes from the first five to ten minutesof the reftest suite with a local debug build on two of my laptops. I'm not sure how much that is on actual try runs but it's worth investigating. On a very beefy desktop the same GC symbols are still getting the biggest scores although they tend to have lower percentages.
Assignee | ||
Comment 2•7 years ago
|
||
I strongly agree. Let's recycle mode 11.
Assignee: nobody → terrence
Status: NEW → ASSIGNED
Flags: needinfo?(terrence)
Attachment #8707594 -
Flags: review?(jcoppeard)
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8707594 [details] [diff] [review] make_marking_validation_a_zeal_mode-v0.diff Review of attachment 8707594 [details] [diff] [review]: ----------------------------------------------------------------- Great! ::: js/src/builtin/TestingFunctions.cpp @@ +788,5 @@ > ReportUsageError(cx, callee, "Wrong number of arguments"); > return false; > } > > + JS_SetGCZeal(cx, 11, 0); This needs to enable / disable validation based on the first argument.
Attachment #8707594 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4257bd7b0039
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7655f1d92370
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a048c55e1906f380a9f95d8f1dfa8308c37629cd Bug 1239314 - Make marking validation a normal zeal mode; r=jonco
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a048c55e1906
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•