MozReview Request: Bug 1239319 - use input types properly for search and url bar to get better OSK support on Windows, r?jaws
58 bytes, text/x-review-board-request
2.40 KB, patch
|Details | Diff | Splinter Review|
Right now we get the default keyboard. If we exposed InputScope IS_URL then we would get a nicer keyboard. TSFTextStore.cpp handles this based on input's type attribute. If we ensure the inner HTML input element has the right type attribute, we should be fine here.
It looks like we need to do something similar for the Search bar. If I click in the Search field of the Windows 10 Settings app, I get an on-screen keyboard with a magnifying glass as the Enter/Return key, whereas Firefox just shows the Enter/Return graphic on that button.
Changing #searchbar's input to use type=search instead of type=autocomplete doesn't generate any different Firefox behavior that I can see, but it does show the Search glass on the OSK with this changed.
It seems that the type="autocomplete" is required to get the right binding (autocomplete.xml) but then that's inherited onto the input element, where it has no meaning. We should support an extra attribute that we inherit there instead, probably something like "htmlinputtype", and then define it on the url and search bindings.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/30981/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30981/
Attachment #8708122 - Flags: review?(jaws)
FWIW, I went with "inputtype" because we already have "inputtooltiptext", so that seemed the more consistent option.
Summary: Use input type="url" inside main location bar to enable better on-screen keyboard support for it on Windows → Use the 'right' HTML input type attributes for the location bar and search bar to get a better on-screen keyboard for them on Windows
Comment on attachment 8708122 [details] MozReview Request: Bug 1239319 - use input types properly for search and url bar to get better OSK support on Windows, r?jaws https://reviewboard.mozilla.org/r/30981/#review27817
Attachment #8708122 - Flags: review?(jaws) → review+
Depends on: 1240181
Depends on: 1240208
The URL bar attribute change was backed out in bug 1240181: https://hg.mozilla.org/mozilla-central/rev/71dec72dcdd5 Bug 1240208 covers finding an alternate solution for the keyboard layout while not causing bug 1240181.
Approval Request Comment [Feature/regressing bug #]: Windows on-screen keyboard support [User impact if declined]: The keyboard doesn't adapt well for search fields in the browser (and/or: conflicts if we try to uplift bug 1240208) [Describe test coverage new/current, TreeHerder]: no [Risks and why]: very low, this is a minor change to XBL bindings used by Firefox for search and other input fields [String/UUID change made/needed]: no.
Attachment #8716247 - Flags: approval-mozilla-beta?
Comment on attachment 8716247 [details] [diff] [review] Patch for beta Improve the windows 10 support, taking it. Should be in 45 beta 5
Attachment #8716247 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in before you can comment on or make changes to this bug.