test_connection_asyncClose.js fails lint checks because of deprecated generator function usage.

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8707498 [details]
MozReview Request: Bug 1239354: Replace old-style generator function with star functions. r?asuth

Review commit: https://reviewboard.mozilla.org/r/30733/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30733/
Attachment #8707498 - Flags: review?(bugmail)
(Assignee)

Updated

3 years ago
Assignee: nobody → dtownsend
Attachment #8707498 - Flags: review?(bugmail) → review+
Comment on attachment 8707498 [details]
MozReview Request: Bug 1239354: Replace old-style generator function with star functions. r?asuth

https://reviewboard.mozilla.org/r/30733/#review27573
I'm very sorry about that; the eslint plugin in atom was throwing all kinds of errors because I use global eslint because of CSP reasons when I invoke atom against only a subtree of gaia.  I tried to globally install the mozilla plugin that was missing, but it's not published on npm, and mach didn't seem to have any magic available.
(Assignee)

Comment 5

3 years ago
(In reply to Andrew Sutherland [:asuth] from comment #4)
> I'm very sorry about that; the eslint plugin in atom was throwing all kinds
> of errors because I use global eslint because of CSP reasons when I invoke
> atom against only a subtree of gaia.  I tried to globally install the
> mozilla plugin that was missing, but it's not published on npm, and mach
> didn't seem to have any magic available.

mach eslint --setup will install the right plugins globally including the mozilla plugin.
(In reply to Dave Townsend [:mossop] from comment #5)
> mach eslint --setup will install the right plugins globally including the
> mozilla plugin.

Ahhhh!  Thank you!  I experienced argument-blindness for "./mach eslint --help" and missed it, and so just ran "./mach bootstrap" and "./mach eslint" each in the hope they'd do things.  (Count me as a vote for having "./mach eslint" prompt/suggest the setup automatically like how "./mach build" will aggressively intercede in certain cases.)
(Assignee)

Comment 8

3 years ago
(In reply to Andrew Sutherland [:asuth] from comment #7)
> (In reply to Dave Townsend [:mossop] from comment #5)
> > mach eslint --setup will install the right plugins globally including the
> > mozilla plugin.
> 
> Ahhhh!  Thank you!  I experienced argument-blindness for "./mach eslint
> --help" and missed it, and so just ran "./mach bootstrap" and "./mach
> eslint" each in the hope they'd do things.  (Count me as a vote for having
> "./mach eslint" prompt/suggest the setup automatically like how "./mach
> build" will aggressively intercede in certain cases.)

Yeah I want to do that in bug 1239139 when I get chance.

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d2200adcf35b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.