Closed Bug 1239363 Opened 5 years ago Closed 5 years ago

Failing to parse marionette.logging preference when it is not a string

Categories

(Testing :: Marionette, defect)

defect
Not set
major

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

Marionette fails to start when the marionette.logging preference isn’t a string:

06:44:13     INFO -  JavaScript error: resource://gre/components/marionettecomponent.js, line 63: TypeError: s.toLowerCase is not a function
Assignee: nobody → ato
Status: NEW → ASSIGNED
The marionette.logging preference used to have a boolean type.
To maintain backwards compatibility with earlier clients we keep accepting
boolean types as input.

Previously setting it to true meant you wanted all the logs, and this
change respects that.

Review commit: https://reviewboard.mozilla.org/r/30741/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30741/
Attachment #8707510 - Flags: review?(dburns)
Attachment #8707510 - Flags: review?(dburns) → review+
Comment on attachment 8707510 [details]
MozReview Request: Bug 1239363 - Accept non-string types for marionette.logging pref; r=AutomatedTester

https://reviewboard.mozilla.org/r/30741/#review27543
Severity: normal → major
https://hg.mozilla.org/mozilla-central/rev/b28a5678774d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
FWIW the OrangeFactor issues here should be resolved by bug 1239371, which is now on inbound.
You need to log in before you can comment on or make changes to this bug.