Failing to parse marionette.logging preference when it is not a string

RESOLVED FIXED in Firefox 46

Status

--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({pi-marionette-server})

unspecified
mozilla46
pi-marionette-server
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Marionette fails to start when the marionette.logging preference isn’t a string:

06:44:13     INFO -  JavaScript error: resource://gre/components/marionettecomponent.js, line 63: TypeError: s.toLowerCase is not a function
(Assignee)

Updated

3 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
(Assignee)

Comment 1

3 years ago
Created attachment 8707510 [details]
MozReview Request: Bug 1239363 - Accept non-string types for marionette.logging pref; r=AutomatedTester

The marionette.logging preference used to have a boolean type.
To maintain backwards compatibility with earlier clients we keep accepting
boolean types as input.

Previously setting it to true meant you wanted all the logs, and this
change respects that.

Review commit: https://reviewboard.mozilla.org/r/30741/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30741/
Attachment #8707510 - Flags: review?(dburns)
Attachment #8707510 - Flags: review?(dburns) → review+
Comment on attachment 8707510 [details]
MozReview Request: Bug 1239363 - Accept non-string types for marionette.logging pref; r=AutomatedTester

https://reviewboard.mozilla.org/r/30741/#review27543
Severity: normal → major
Comment hidden (Intermittent Failures Robot)

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b28a5678774d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment hidden (Intermittent Failures Robot)
(Assignee)

Comment 7

3 years ago
FWIW the OrangeFactor issues here should be resolved by bug 1239371, which is now on inbound.
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.