Closed Bug 1239371 Opened 5 years ago Closed 5 years ago

Consider state of boolean values for marionette.logging preference

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

In my previous patch for bug 1239363 the marionette.logging preference is treated in a defined/undefined state, and it doesn’t look specifically at the state of the variable itself.

This means i.e. that if it is set to false, logging will still be enabled which was not the original behaviour.
Assignee: nobody → ato
Status: NEW → ASSIGNED
The patch for bug 1239363 treated the marionette.logging preference as
a defined/undefined state, and didn't look specifically at the state of
the variable itself.

This meant that if it was set to false, logging would still be enabled.
As this was not the original behaviour were adding backwards compatibility
for, this patch corrects this problem by making false equivalent to the
default (Log.Level.Info).

Review commit: https://reviewboard.mozilla.org/r/30751/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30751/
Attachment #8707545 - Flags: review?(dburns)
Comment on attachment 8707545 [details]
MozReview Request: Bug 1239371 - Consider state of boolean values for marionette.logging pref; r?AutomatedTester

Please read the commit message which explains the changes.  Does this make sense to you, Maja?

We could make false be equivalent to something less fine-grained, such as Log.Level.Warn or Log.Level.Fatal, but I’d preferably want fewer defaults.
Attachment #8707545 - Flags: feedback?(mjzffr)
Attachment #8707545 - Flags: feedback?(mjzffr) → feedback+
Comment on attachment 8707545 [details]
MozReview Request: Bug 1239371 - Consider state of boolean values for marionette.logging pref; r?AutomatedTester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30751/diff/1-2/
Attachment #8707545 - Flags: feedback+
Comment on attachment 8707545 [details]
MozReview Request: Bug 1239371 - Consider state of boolean values for marionette.logging pref; r?AutomatedTester

https://reviewboard.mozilla.org/r/30751/#review27667
Attachment #8707545 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/54427ab62f79
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.