Closed Bug 1239373 Opened 4 years ago Closed 4 years ago

Enable xpcshell tests for Marionette

Categories

(Testing :: Marionette, defect, P2)

defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

(Keywords: pi-marionette-server)

Attachments

(3 files)

In order to increase the test coverage of Marionette we should add unit tests for Marionette in the form of xpcshell tests.

Currently there are significant areas of Marionette internals that are not tested because they are inaccessible or difficult to test through the client protocol.
Priority: -- → P2
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8709125 [details]
MozReview Request: Bug 1239373 - Infrastructure for Marionette xpcshell unit tests; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31281/diff/1-2/
Comment on attachment 8709126 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/error.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31283/diff/1-2/
Comment on attachment 8709127 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/message.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31285/diff/1-2/
Comment on attachment 8709125 [details]
MozReview Request: Bug 1239373 - Infrastructure for Marionette xpcshell unit tests; r?automatedtester

https://reviewboard.mozilla.org/r/31281/#review28053
Attachment #8709125 - Flags: review?(dburns) → review+
Attachment #8709126 - Flags: review?(dburns) → review+
Comment on attachment 8709126 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/error.js; r?automatedtester

https://reviewboard.mozilla.org/r/31283/#review28055
Attachment #8709127 - Flags: review?(dburns) → review+
Comment on attachment 8709127 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/message.js; r?automatedtester

https://reviewboard.mozilla.org/r/31285/#review28059
There doesnt appear to be any patches for getting this running on infrastructure, you might want to either add a new patch for that or raise a separate bug and get it done there. Choice is yours.
Thanks for the reviews!

(In reply to David Burns :automatedtester from comment #10)
> There doesnt appear to be any patches for getting this running on
> infrastructure, you might want to either add a new patch for that or raise a
> separate bug and get it done there. Choice is yours.

If I understand this correctly, adding a new manifest to XPCSHELL_TEST_MANIFESTS I think will make them run as part of the X jobs on Treeherder.

Will confirm in try run.
try run where head and tail entries are explicitly defined in unit.ini: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4415f56d33fe
Comment on attachment 8709125 [details]
MozReview Request: Bug 1239373 - Infrastructure for Marionette xpcshell unit tests; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31281/diff/2-3/
Comment on attachment 8709126 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/error.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31283/diff/2-3/
Comment on attachment 8709127 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/message.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31285/diff/2-3/
Comment on attachment 8709125 [details]
MozReview Request: Bug 1239373 - Infrastructure for Marionette xpcshell unit tests; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31281/diff/3-4/
Comment on attachment 8709126 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/error.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31283/diff/3-4/
Comment on attachment 8709127 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/message.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31285/diff/3-4/
Comment on attachment 8709125 [details]
MozReview Request: Bug 1239373 - Infrastructure for Marionette xpcshell unit tests; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31281/diff/4-5/
Comment on attachment 8709126 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/error.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31283/diff/4-5/
Comment on attachment 8709127 [details]
MozReview Request: Bug 1239373 - Tests for testing/marionette/message.js; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31285/diff/4-5/
https://hg.mozilla.org/mozilla-central/rev/5dbf390b7afa
https://hg.mozilla.org/mozilla-central/rev/73f9ba910ce2
https://hg.mozilla.org/mozilla-central/rev/faa5b203149a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Depends on: 1242081
You need to log in before you can comment on or make changes to this bug.