Closed Bug 1239426 Opened 4 years ago Closed 4 years ago

eslint components-import rule does not handle arrow functions

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

Attachments

(1 file)

For devtools/server/actors/styles.js I am seeing eslint reports like
"DOMUtils is not defined" in various spots.  However DOMUtils is defined as:

loader.lazyGetter(this, "DOMUtils", () => {
  return Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);
});


I tracked the problem down to getASTSource not handling arrow functions.
Blocks: eslint
Attachment #8707585 - Flags: review?(mratcliffe)
Comment on attachment 8707585 [details] [diff] [review]
handle arrow functions in getASTSource

Review of attachment 8707585 [details] [diff] [review]:
-----------------------------------------------------------------

I had been planning on looking at this so thanks for the fix!
Attachment #8707585 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/4967385058ee
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.