Closed Bug 1239480 Opened 7 years ago Closed 7 years ago

test_TelemetryReportingPolicy.js is going to permafail when Gecko 45 merges to Beta

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Type:
defect

Tracking

(firefox44 unaffected, firefox45+ fixed, firefox46+ fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 46
Tracking Flags:
Tracking Status
firefox44 --- unaffected
firefox45 + fixed
firefox46 + fixed

People

(Reporter: RyanVM, Assigned: Dexter)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file, 2 obsolete files)

bug1239480.patch
3.61 KB, patch
gfritzsche
: review+
RyanVM
: feedback+
Details | Diff | Splinter Review 
[Tracking Requested - why for this release]: Merge day bustage, which we all love so much.

https://treeherder.mozilla.org/logviewer.html#?job_id=15414636&repo=try

TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryReportingPolicy.js | test_prefs - [test_prefs : 116] A greater minimum policy version must invalidate the policy and disable upload. - false == true
Flags: needinfo?(alessio.placitelli)
Points: --- → 2
Flags: needinfo?(alessio.placitelli)
Priority: -- → P1
Whiteboard: [measurement:client]
Assignee: nobody → alessio.placitelli
Attached patch bug1184458.patch (obsolete) — — Splinter Review 
So, two issues there:

1) The test should make sure to set the minimum policy version for the right channel (as of now, we only have an override for the beta channel). That's what the patch does.
2) The test didn't fail on the current beta as [0] doesn't return "beta" in the xpcshell test there.

[0] - https://dxr.mozilla.org/mozilla-central/rev/4e2224c009dfedfcd95035e2fc67779567c2cdea/toolkit/modules/UpdateUtils.jsm#33
Attachment #8707846 - Flags: review?(gfritzsche)
Comment on attachment 8707846 [details] [diff] [review]
bug1184458.patch

Review of attachment 8707846 [details] [diff] [review]:
-----------------------------------------------------------------

I think you uploaded the wrong patch.
Attachment #8707846 - Flags: review?(gfritzsche)
Attached patch bug1239480.patch (obsolete) — — Splinter Review 
Ouch. Indeed. Sorry about that.
Attachment #8707846 - Attachment is obsolete: true
Attachment #8707927 - Flags: review?(gfritzsche)
Attachment #8707927 - Attachment is obsolete: true
Attachment #8707927 - Flags: review?(gfritzsche)
Attached patch bug1239480.patch — — Splinter Review 
Yeah, this time is for real.
Attachment #8707931 - Flags: review?(gfritzsche)
Attachment #8707931 - Flags: review?(gfritzsche) → review+
Tracking for 45+ to keep an eye on this and make sure it lands successfully.
tracking-firefox45: ? → +
tracking-firefox46: ? → +
Comment on attachment 8707931 [details] [diff] [review]
bug1239480.patch

Looks good on Try. This can land on Aurora a=test-only whenever.
Attachment #8707931 - Flags: feedback+
Whiteboard: [measurement:client] → [measurement:client][checkin-needed-aurora]
https://hg.mozilla.org/mozilla-central/rev/517fcf1b9608
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
https://hg.mozilla.org/releases/mozilla-aurora/rev/7990e9d7ec79
status-firefox45: affected → fixed
Whiteboard: [measurement:client][checkin-needed-aurora] → [measurement:client]
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.