Closed
Bug 1239494
Opened 5 years ago
Closed 5 years ago
Use stable hashing and builtin tracing for sJSObjWrappers
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
8.04 KB,
patch
|
jonco
:
review+
mccr8
:
feedback+
|
Details | Diff | Splinter Review |
Seems to get rid of a bunch of insanity. This stuff is tricky though, so try run at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c035ef25442
Attachment #8707659 -
Flags: review?(bugs)
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
Comment on attachment 8707659 [details] [diff] [review] gchashmap_for_wrapper_cache-v0.diff I'm sure mccr8 wants to review this :) (I'm tiny bit overloaded with reviews today)
Attachment #8707659 -
Flags: review?(bugs) → review?(continuation)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 8707659 [details] [diff] [review] gchashmap_for_wrapper_cache-v0.diff Review of attachment 8707659 [details] [diff] [review]: ----------------------------------------------------------------- It looks like these changes are all purely for the JS stable hashing stuff, so I think somebody who is actually familiar with it should review it. Thanks for checking, though.
Attachment #8707659 -
Flags: review?(jcoppeard)
Attachment #8707659 -
Flags: review?(continuation)
Attachment #8707659 -
Flags: feedback+
|
||
Comment 3•5 years ago
|
||
Comment on attachment 8707659 [details] [diff] [review] gchashmap_for_wrapper_cache-v0.diff Review of attachment 8707659 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8707659 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/89a5dfce0c0760900b58dc2efbccc2b36605baca Bug 1239494 - Use GCHashMap to simplify nsWrapperCache; r=jonco
|
|
Assignee | |
Comment 5•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2878f9631c63fecd9c417208bc4529c784ff515e Bug 1239494 - Followup to fix a spurious hazard analysis failure; r=meow
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/89a5dfce0c07 https://hg.mozilla.org/mozilla-central/rev/2878f9631c63
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•