Closed Bug 1239494 Opened 6 years ago Closed 6 years ago

Use stable hashing and builtin tracing for sJSObjWrappers

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

gchashmap_for_wrapper_cache-v0.diff
8.04 KB, patch
jonco
: review+
mccr8
: feedback+
Details | Diff | Splinter Review 
Seems to get rid of a bunch of insanity. This stuff is tricky though, so try run at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c035ef25442
Attachment #8707659 - Flags: review?(bugs)
Blocks: 1194544
No longer blocks: 119454
Comment on attachment 8707659 [details] [diff] [review]
gchashmap_for_wrapper_cache-v0.diff

I'm sure mccr8 wants to review this :)
(I'm tiny bit overloaded with reviews today)
Attachment #8707659 - Flags: review?(bugs) → review?(continuation)
Comment on attachment 8707659 [details] [diff] [review]
gchashmap_for_wrapper_cache-v0.diff

Review of attachment 8707659 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like these changes are all purely for the JS stable hashing stuff, so I think somebody who is actually familiar with it should review it. Thanks for checking, though.
Attachment #8707659 - Flags: review?(jcoppeard)
Attachment #8707659 - Flags: review?(continuation)
Attachment #8707659 - Flags: feedback+
Comment on attachment 8707659 [details] [diff] [review]
gchashmap_for_wrapper_cache-v0.diff

Review of attachment 8707659 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8707659 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/89a5dfce0c07
https://hg.mozilla.org/mozilla-central/rev/2878f9631c63
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.