Closed Bug 1239503 Opened 4 years ago Closed 4 years ago
Don't include URL when sharing text
58 bytes, text/x-review-board-request
Let's revert the change from bug 1171929. I think there is value around giving people more options when sharing text from the browser, but the approach taken in bug 1171929 isn't working for users, so we should revert it. We're too late for 44, but we could uplift this to have it in 45.
Review commit: https://reviewboard.mozilla.org/r/31233/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31233/
Attachment #8709031 - Flags: review?(s.kaspari)
Comment on attachment 8709031 [details] MozReview Request: Bug 1239503 - Don't include URL when sharing text. r=sebastian https://reviewboard.mozilla.org/r/31233/#review28001
Attachment #8709031 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/101c5632ebe7986b27f8d03f05ab3d6c8461d203 Bug 1239503 - Don't include URL when sharing text. r=sebastian
Comment on attachment 8709031 [details] MozReview Request: Bug 1239503 - Don't include URL when sharing text. r=sebastian Approval Request Comment [Feature/regressing bug #]: bug 1171929 [User impact if declined]: URL appended to selected text when shared, which we've found that users don't really like [Describe test coverage new/current, TreeHerder]: tested locally [Risks and why]: low-risk, small change to selected text share logic [String/UUID change made/needed]: none
Attachment #8709031 - Flags: approval-mozilla-aurora?
Attachment #8709031 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
When sharing text, the URL is not included: Verified as fixed using: Device: Nexus 6 (Android 6.0) Build: Firefox for Android 46.0a1 (2015-01-24)
Added to the 45 release notes Disable the inclusion of the URL when sharing selected text from web page
Could we have an option to enable including URL when sharing text? I understand some people have issues with it as expressed in 1171929, but I think for certain scenarios, it'd be quite useful to have this. If there is an option (disabled by default), users who need it can choose to enable it to suit his/her purpose. If a new bug request needs to be filed to have this option, please let me know and I'll file one. Thanks.
You need to log in before you can comment on or make changes to this bug.