Closed Bug 1239515 Opened 5 years ago Closed 5 years ago

Replace HashSet::rekeyInPlace with something slightly saner

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

This adds two assertions, removes one const_cast, and one level of indirection from the API. Now it explicitly overwrites the key instead of relying on HashMap::rekey to do something which may be even less sane.

This passes jit-tests, which is probably going to exercise this path as much as anything, but here's a try run to be sure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3001c83fdb81
Attachment #8707678 - Flags: review?(sunfish)
Comment on attachment 8707678 [details] [diff] [review]
simplify_rekeyInPlace-v0.diff

Review of attachment 8707678 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! I like the extra asserts around this operation :).
Attachment #8707678 - Flags: review?(sunfish) → review+
https://hg.mozilla.org/mozilla-central/rev/3aabb2f49d41
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.