Closed
Bug 1239515
Opened 10 years ago
Closed 10 years ago
Replace HashSet::rekeyInPlace with something slightly saner
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
2.82 KB,
patch
|
sunfish
:
review+
|
Details | Diff | Splinter Review |
This adds two assertions, removes one const_cast, and one level of indirection from the API. Now it explicitly overwrites the key instead of relying on HashMap::rekey to do something which may be even less sane.
This passes jit-tests, which is probably going to exercise this path as much as anything, but here's a try run to be sure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3001c83fdb81
Attachment #8707678 -
Flags: review?(sunfish)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8707678 [details] [diff] [review]
simplify_rekeyInPlace-v0.diff
Review of attachment 8707678 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! I like the extra asserts around this operation :).
Attachment #8707678 -
Flags: review?(sunfish) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aabb2f49d41f83d8d296bd893336411e29b29c5
Bug 1239515 - Simplify HashSet's key-overwriting interface; r=sunfish
|
|
||
Comment 3•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•