Closed Bug 1239524 Opened 5 years ago Closed 5 years ago

Can't publish review request with no reviewers

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: botond, Assigned: gps)

Details

(Keywords: regression)

Attachments

(1 file)

STR:
  1. Create a local commit with an "r=<nick>" in the commit message.
     (Presumably "r?<nick>" has the same effect.)
  2. Push the commit to MozReview. Choose not to publish it on the
     command line.
  3. In the MozReview UI, delete the deduced reviewer.
  4. Try to publish the review request.

Expeected results:
  The review request is published successfully.

Actual results:
  "There must be at least one reviewer before this review request can be published"

This used to work.
The web UI enforces the requirement that a review request have
reviewers. This behavior is different from the web API, which doesn't
enforce this requirement.

As part of converting to the batch submission API, we failed to carry
over the setting of default reviewers from DiffResource.create() from
the Review Board Web API. This commit fixes that.

Review commit: https://reviewboard.mozilla.org/r/30837/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30837/
Attachment #8707689 - Flags: review?(smacleod)
Comment on attachment 8707689 [details]
MozReview Request: mozreview: add default reviewers the first time we add a diffset (bug 1239524); r?smacleod

https://reviewboard.mozilla.org/r/30837/#review27611
Attachment #8707689 - Flags: review?(smacleod) → review+
Autolanded.
Assignee: nobody → gps
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.