Closed Bug 1239587 Opened 4 years ago Closed 4 years ago

Rename the browser.safebrowsing.appRepURL pref

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

Attachments

(1 file)

From Hector Zhao:

The document[1] says "Whenever we change a pref in a hotfix, we need to change the pref name in Firefox, otherwise users will get stuck with this custom value which won't be reset when Firefox updates". Since "browser.safebrowsing.appRepURL" is set in [2], maybe you should rename the pref in [3]? Sorry if this was already raised and considered in the bug.

Also, there's a "browser.safebrowsing.provider.google.appRepURL" left in mobile/android/app/mobile.js.

[1]: https://wiki.mozilla.org/Firefox/Hotfix#How_to_develop_a_new_hotfix
[2]: http://hg.mozilla.org/releases/firefox-hotfixes/file/tip/v20160106.01/bootstrap.js#l10
[3]: https://hg.mozilla.org/mozilla-central/rev/8dff95d86acb
I took care of the stray mobile/android/app/mobile.js pref in bug 1237132.
Attached patch bug1239587.patchSplinter Review
Attachment #8709207 - Flags: review?(gpascutto)
Attachment #8709207 - Flags: review?(gpascutto) → review+
QA Contact: mwobensmith
https://hg.mozilla.org/mozilla-central/rev/eccae3a7bdb2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.