1239611 - Remove GonkNativeWindowClient

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sotaro Ikeda [:sotaro]]

Removing GonkNativeWindowClient could simplify GonkNativeWindow.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove GonkNativeWindowClient

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8708149 [details] [diff] [review]
patch - Remove GonkNativeWindowClient

Review of attachment 8708149 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, less code! What did we add as a replacement?

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Nicolas Silva [:nical] from comment #2)
> Comment on attachment 8708149 [details] [diff] [review]
> patch - Remove GonkNativeWindowClient
> 
> Review of attachment 8708149 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yay, less code! What did we add as a replacement?

andorid::Surface(ANativeWindow) replaced it.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> (In reply to Nicolas Silva [:nical] from comment #2)
> > Comment on attachment 8708149 [details] [diff] [review]
> > patch - Remove GonkNativeWindowClient
> > 
> > Review of attachment 8708149 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Yay, less code! What did we add as a replacement?
> 
> andorid::Surface(ANativeWindow) replaced it.

camera preview always have to use andorid::Surface. Then usage was unified to it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f67d4ae739db

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f67d4ae739db