Closed
Bug 1239636
Opened 8 years ago
Closed 8 years ago
[Call log] Deleting all the missed calls does not remove the data labels of each entry
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)
Tracking
(blocking-b2g:2.6+, b2g-master verified)
People
(Reporter: isabel_rios, Assigned: gsvelto)
References
Details
Attachments
(2 files)
[Pre-requisites] Have one or more missed calls [Procedure] Open Dialer and go to Call log Tap on Missed tab Delete all the entries [Actual] The label with the date of the missed calls is not removed. Please see screenshot attached. Going to All tab and again to Missed tabs shows the correct screen without any entry or date [Expected] All entries are correctly removed and No missed calls message should appear Seen on Aries 2.6 latest dogfood build: Build ID 20151230211515 Gaia Revision f3cf488a97ecaec43369f3e3d8a7dda52be019f9 Gaia Date 2015-12-22 02:20:26 Gecko Revision ff1d0474af716e9108b386c863d799cf4916cd67 Gecko Version 46.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151230.195810 Firmware Date Wed Dec 30 19:58:20 UTC 2015 Bootloader s1 And flame 2.6: Build ID 20160112105459 Gaia Revision 3c97d6a8ac5a69662e1e2c22a84ea59bf50c305e Gaia Date 2016-01-12 06:35:13 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/e790bba372f14241addda469a4bdb7ab00786ab3 Gecko Version 46.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20160112.112221 Firmware Date Tue Jan 12 11:22:34 UTC 2016 Bootloader L1TC000118D0
Reporter | ||
Updated•8 years ago
|
blocking-b2g: --- → 2.6?
Reporter | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
I've tried reproducing but I get a slightly different behavior (though still wrong): the "Today" label is remove along with all the missed calls, but the text at the center of the screen says "No calls recorded Start a conversation now" instead of "No missed calls".
Assignee | ||
Comment 3•8 years ago
|
||
OK, I've found out where the difference comes from. If I have a regular call in an existing label (Today) under the "All" tab and I delete all the missed calls from the "Missed" tab the label is still visible as per comment 0. It seems that we're leaving around part of the "All" tab layout when we delete calls in the "Missed" tab.
Assignee | ||
Comment 4•8 years ago
|
||
While testing the fix for this bug I noticed another issue: when deleting all missed calls we also delete all the non-missed ones. Yuck.
Reporter | ||
Comment 5•8 years ago
|
||
Hi Gabriele, I cannot see that...If I remove the missed calls from Missed tab, selecting all, the incoming calls in All tab remains there...maybe I am missing some step or condition. Thanks!
Assignee | ||
Comment 6•8 years ago
|
||
Oh yeah, it's not visible. We delete all the calls from the database but not from the screen so it appears as if the calls are still there. Patch pending fixing both bugs.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment 7•8 years ago
|
||
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8708330 [details] [review] [gaia] gabrielesvelto:bug-1239636-delete-missed-entries-fix > mozilla-b2g:master This patch fixes both the issue described in the bug as well as another one which I noticed while testing: when deleting all missed calls we would delete all the calls from the database - including not missed ones. However the list wouldn't be updated to reflect it leaving it in an inconsistent state. I've removed the offending code since it wasn't needed either.
Attachment #8708330 -
Flags: review?(thills)
Comment 9•8 years ago
|
||
Comment on attachment 8708330 [details] [review] [gaia] gabrielesvelto:bug-1239636-delete-missed-entries-fix > mozilla-b2g:master Hi Gabriele, It looks good and I can see how it solves the problem. I wanted to check, what do you think about adding a test to call_log_test under the 'Edit Mode' suite for this to check whether the filter or unfilter was called as appropriate? Thanks, -tamara
Attachment #8708330 -
Flags: review?(thills)
Reporter | ||
Updated•8 years ago
|
blocking-b2g: 2.6? → 2.6+
Priority: -- → P1
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8708330 [details] [review] [gaia] gabrielesvelto:bug-1239636-delete-missed-entries-fix > mozilla-b2g:master I should have added unit-tests right away, I've pushed another patch on top of the PR with the appropriate tests.
Attachment #8708330 -
Flags: review?(thills)
Comment 11•8 years ago
|
||
Comment on attachment 8708330 [details] [review] [gaia] gabrielesvelto:bug-1239636-delete-missed-entries-fix > mozilla-b2g:master Hi Gabriele, It looks good, thanks for adding the tests. -tamara
Attachment #8708330 -
Flags: review?(thills) → review+
Assignee | ||
Comment 12•8 years ago
|
||
Thanks Tamara, merged to gaia/master 4226fc5039ef555d92227acfc1911f2ef892601c https://github.com/mozilla-b2g/gaia/commit/4226fc5039ef555d92227acfc1911f2ef892601c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•8 years ago
|
status-b2g-master:
--- → fixed
Comment 13•8 years ago
|
||
This issue is verified fixed on Flame and Aries 2.6. All entries are correctly removed and no data labels appear. Environmental Variables: Device: Aries 2.6 BuildID: 20160224110426 Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c Gecko: d848a5628d801a460a7244cbcdea22d328d8b310 Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56 Version: 47.0a1 (2.6) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:47.0) Gecko/47.0 Firefox/47.0 Environmental Variables: Device: Flame 2.6 BuildID: 20160225030411 Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c Gecko: c1e0d1890cfee9d86c8d566b0490053f21e0afc6 Gonk: 8a066f7fa7410e32b58def35f322aa33f03db283 Version: 47.0a1 (2.6) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:47.0) Gecko/47.0 Firefox/47.0 ***************************** This issue still occurs on Flame 2.5 builds. The label with the date of the missed calls is not removed. Environmental Variables: Device: Flame 2.5 BuildID: 20160208174403 Gaia: 28880004bc5cd6e129d0a23b701a389753788ed0 Gecko: 4ee75807aba47e9176644ec5cd498c8ff73ac08a Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a Version: 44.0 (2.5) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•8 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•