1239659 - test-eslintbot.t fails due to missing eslint

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Dan Minor [:dminor]]

It appears that the eslintbot tests assume that eslint is installed locally:

   $ python -m eslintbot --config-path ../eslintbot.ini
   INFO:mozreviewbot:reviewing revision: 265cd5106b1c (review request: 2)
+  Traceback (most recent call last):
+    File "./mach", line 4, in <module>
+      subprocess.call(["eslint"] + sys.argv[1:])
+    File "/usr/lib/python2.7/subprocess.py", line 522, in call
+      return Popen(*popenargs, **kwargs).wait()
+    File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
+      errread, errwrite)
+    File "/usr/lib/python2.7/subprocess.py", line 1335, in _execute_child
+      raise child_exception
+  OSError: [Errno 2] No such file or directory
+  Traceback (most recent call last):
+    File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
+      "__main__", fname, loader, pkg_name)
+    File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
+      exec code in run_globals
+    File "/home/dminor/src/version-control-tools/pylib/mozreviewbots/eslintbot/__main__.py", line 157, in <module>
+      bot.handle_available_messages()
+    File "/home/dminor/src/version-control-tools/pylib/mozreviewbots/mozreviewbotlib/__init__.py", line 258, in handle_available_messages
+      commit)
+    File "/home/dminor/src/version-control-tools/pylib/mozreviewbots/eslintbot/__main__.py", line 74, in process_commit
+      subprocess.check_output(args)
+    File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
+      raise CalledProcessError(retcode, cmd, output=output)
+  subprocess.CalledProcessError: Command '['./mach', 'eslint', '--format=json', '--output-file=/tmp/tmpHmX1t3', 'test.js']' returned non-zero exit status 1
+  [1]
 
We should probably install it as part of create-test-environment.

Comment 1

[Mark Banner (:standard8)]

Is this still an issue? I'm guessing possibly not now?

Comment 2

[:glob ✱]

correct - mozreviewbots were never implemented.