Closed Bug 1239672 Opened 5 years ago Closed 5 years ago

Fix symbols file support on mingw.

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox46 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file, 1 obsolete file)

fix
3.89 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) — — Splinter Review 
Bug 1235132 introduced a few problems on mingw:

- linker invocation used UNIX-style (-Wl,--version-script,), while the proper way to pass .def file on mingw is just the file name.
- generate_symbols_file.py generated UNIX-style scripts. This is fixed by reordering the code.
- GCC recognizes .def files by file extensions (and AFAIK there is no way to explicitly tell GCC to treat given file as .def file). I changed generated file name use .def extension.

Here is try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa42ce541ca2
Attachment #8707864 - Flags: review?(mh+mozilla)
Comment on attachment 8707864 [details] [diff] [review]
fix

Review of attachment 8707864 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/data.py
@@ +497,5 @@
>          else:
>              self.soname = self.lib_name
>  
>          if symbols_file:
> +            self.symbols_file = '%s.def' % self.lib_name

Please make this windows-only.
Attachment #8707864 - Flags: review?(mh+mozilla)
Attached patch fix — — Splinter Review 
Thanks for review.

Try pushed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c0857152ec0
Attachment #8707864 - Attachment is obsolete: true
Attachment #8708326 - Flags: review?(mh+mozilla)
Attachment #8708326 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/7698955aac90
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.