Closed Bug 1239679 Opened 4 years ago Closed 4 years ago

Very frequent crashes of mm-qcamera-daemon on Z3c L

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(5 files)

Taking pictures often crashes the daemon. This is because missing fakebattery and sensorservice.
This is the same thing we faced with KK port:
 - building and running fakebattery service
 - running sensorservice

The latter is just a matter of adding entry in init.rc. But the former requires some code. Right now, that code does live solely in the shinano-common device repo because it was only useful to that device.

Now that this will be useful and shared, I suggest we move that to a new repo, maybe hardware/sony/fakebattery ? And we remove that code from shinano-common too.
This is where the code lives right now: https://github.com/mozilla-b2g/device-shinano-common/tree/master/fakebattery
Flags: needinfo?(mwu)
Moving to a new repo sounds fine to me.
Flags: needinfo?(mwu)
After thinking again I think we can just do like fakeappsops and just hav ethat living within gonk-misc. Adding a new repo involves manifest changes, mirroring etc.
Attached file Gonk-misc PR
Attachment #8708387 - Flags: review?(mwu)
Attached file Shinano common PR
Attachment #8708388 - Flags: review?(mwu)
Comment on attachment 8708387 [details] [review]
Gonk-misc PR

nit: inconsistent indentation in fakebattery.cpp.
Attachment #8708387 - Flags: review?(mwu) → review+
Attachment #8708388 - Flags: review?(mwu) → review+
Attached file Shinano platform PR
Attachment #8708397 - Flags: review?(mwu)
Attached file Rhine platform PR
Attachment #8708399 - Flags: review?(mwu)
(In reply to Michael Wu [:mwu] from comment #7)
> Comment on attachment 8708387 [details] [review]
> Gonk-misc PR
> 
> nit: inconsistent indentation in fakebattery.cpp.

Should be good now :)
Attached file Yukon platform PR
Attachment #8708401 - Flags: review?(mwu)
Attachment #8708397 - Flags: review?(mwu) → review+
Attachment #8708399 - Flags: review?(mwu) → review+
Attachment #8708401 - Flags: review?(mwu) → review+
Whiteboard: [systemsfe]
Target Milestone: --- → 2.6 S5 - 1/15
You need to log in before you can comment on or make changes to this bug.