1239732 - Developer page shows both Desktop and Android download buttons on IE6

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

I noticed the download buttons on the /firefox/developer/ page are missing the platform='desktop' parameter: https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/developer.html#L43

This has the side effect of showing two download buttons in IE6, one for Firefox Dev Edition and one for Fennec. It took me a while to figure out, but this is because IE6 does not support multiple CSS class selectors correctly:

https://github.com/mozilla/bedrock/blob/master/media/css/sandstone/buttons.less#L796

Here, IE6 ignores the .android class, and styles the .x86 class. This highlights the over-complexity of our download button code well :/

Fixing the button code is a much larger project of it's own, so for now it is going to be easier just to make sure we add the platform parameter to the download button on this page.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a75fcc6cc2f841027d393ea70dfde20c14d6b39e
[fix bug 1239732] Developer page shows both Desktop and Android download buttons on IE6

- Also fix Dev Edition download button on /firefox/installer-help page

https://github.com/mozilla/bedrock/commit/8746a0c65fcb72237caef5e84ab881c8a7092516
Merge pull request #3782 from alexgibson/bug-1239732-developer-button-ie6

[fix bug 1239732] Developer page shows both Desktop and Android downoad buttons on IE6