Closed Bug 1239738 Opened 7 years ago Closed 7 years ago

Fennec artifact builds busted: AttributeError: 'NoneType' object has no attribute 'match'

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Collecting pylru==1.0.9
  Using cached pylru-1.0.9.tar.gz
Installing collected packages: pylru
  Running setup.py install for pylru
Successfully installed pylru-1.0.9
 0:01.25 Installing from local revision 8cb84bef02030a00f25c4faace00c5ac1e525e70
Error running mach:

    ['artifact', 'install']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'NoneType' object has no attribute 'match'

  File "/Users/andrzejhunt/ff/fx3/python/mozbuild/mozbuild/mach_commands.py", line 1507, in artifact_install
    retcode = artifacts.install_from(source, self.bindir, install_callback=install_callback)
  File "/Users/andrzejhunt/ff/fx3/python/mozbuild/mozbuild/artifacts.py", line 768, in install_from
    return self.install_from_hg(source, bindir, install_callback=install_callback)
  File "/Users/andrzejhunt/ff/fx3/python/mozbuild/mozbuild/artifacts.py", line 737, in install_from_hg
    urls = task_cache.artifact_urls(self._tree, self._job, pushhead)
  File "/Users/andrzejhunt/ff/fx3/python/mozbuild/mozbuild/artifacts.py", line 400, in wrapper
    result = method(self, *args, **kwargs)
  File "/Users/andrzejhunt/ff/fx3/python/mozbuild/mozbuild/artifacts.py", line 555, in artifact_urls
    for artifact_name in artifact_job.find_candidate_artifacts(artifacts):
  File "/Users/andrzejhunt/ff/fx3/python/mozbuild/mozbuild/artifacts.py", line 128, in find_candidate_artifacts
    elif self._tests_re.match(name):
Comment on attachment 8707956 [details]
MozReview Request: Bug 1239738 - Handle artifact builds with no test binaries cleanly. r?ahunt

https://reviewboard.mozilla.org/r/30921/#review27733

Works, and fixes the build!
Attachment #8707956 - Flags: review?(ahunt) → review+
https://hg.mozilla.org/mozilla-central/rev/2c23bb770b54
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.