1239748 - Add UI for the windows on screen keyboard master pref

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:Gijs (he/him)]

Per discussion with Jared, this seems like something that we can use to reduce the impact when users are unhappy about the behaviour of the OSK (for instance, because we don't recognize their keyboard adequately). It seems different win8 users have different expectations/experiences here, and it's unlikely that we will be able to please everyone (though we will continue to improve the feature so we do a better job without people having to toggle prefs).

Proposed wording:

"Automatically show a touch keyboard when necessary"

only to be shown if we're on an OS where the pref is supported (so win10, or win8(.1) iff the ui.osk.require_win10 pref is false).

Proposed placement: under the "accessibility" subheading of the "General" portion of the "Advanced" prefs.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1239748 - add a user-facing preference to turn off the on-screen keyboard functionality completely, r?jaws

Review commit: https://reviewboard.mozilla.org/r/31627/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31627/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8709988 [details]
MozReview Request: Bug 1239748 - add a user-facing preference to turn off the on-screen keyboard functionality completely, r?jaws

https://reviewboard.mozilla.org/r/31627/#review28347

::: browser/components/preferences/in-content/advanced.js:321
(Diff revision 1)
> +    let minVersion = Services.prefs.getBoolPref("ui.osk.require_win10") ? 6.4 : 6.2;

Shouldn't this be 10 instead of 6.4? Mathematically they should be equivalent, but I don't recall seeing other parts of our codebase using 6.4 instead of 10.

::: browser/components/preferences/in-content/advanced.js:323
(Diff revision 1)
> +      document.getElementById("useOnScreenKeyboard").removeAttribute("hidden");

We should be able to use hidden=false here, right? Or is there a problem with the binding not being created yet?

::: browser/locales/en-US/chrome/browser/preferences/advanced.dtd:17
(Diff revision 1)
> +<!ENTITY useOnScreenKeyboard.label       "Automatically show a touch keyboard when necessary">

To match the Windows 10 Settings dialog, we should use "the touch keyboard" and I think we can leave off "Automatically", so this would be "Show the touch keyboard when necessary".

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8df98e9a4baf

Comment 4

[:Gijs (he/him)]

(In reply to Pulsebot from comment #3)
> https://hg.mozilla.org/integration/fx-team/rev/8df98e9a4baf

I adjusted for the feedback in comment #2, but I also made the version comparison "manual" -- getting the require_win10 pref would throw on non-Windows, because it only exists on Windows.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8df98e9a4baf

Comment 6

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected