NewTabURL.override is deprecated so use aboutNewTabService.newTabURL instead

RESOLVED INVALID

Status

Hello (Loop)
Client
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1204983 switched the API to aboutNewTabService.newTabURL
Created attachment 8708001 [details] [review]
[loop] Mardak:bug-1239783-newTabURL > mozilla:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8708001 [details] [review]
[loop] Mardak:bug-1239783-newTabURL > mozilla:master

Changes came from bug 1204983 comment 89
Attachment #8708001 - Flags: review?(dmose)
Comment on attachment 8708001 [details] [review]
[loop] Mardak:bug-1239783-newTabURL > mozilla:master

Looks good to me; r=dmose
Attachment #8708001 - Flags: review?(dmose) → review+
(Assignee)

Comment 4

3 years ago
So... as abr noted in bug 1238682 comment 10, the deprecation warning has been removed by bug 1239085.

Do we mark this bug as wontfix or invalid? Or perhaps just land it?
Depends on: 1239085
(Assignee)

Updated

3 years ago
Flags: needinfo?(standard8)
(Assignee)

Comment 5

3 years ago
After reading through more of bug 1204983 leading to bug 1239085, I think abr's conclusion of keeping what we have now makes sense. In particular NewTabURL API was made for add-ons and will be kept around without deprecation warning, so loop as an add-on should use it.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(standard8)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.