The default bug view has changed. See this FAQ.

Mac NSPR needs to call MPLibraryIsLoaded

RESOLVED WONTFIX

Status

NSPR
NSPR
P1
normal
RESOLVED WONTFIX
15 years ago
14 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

other
PowerPC
Mac System 9.x

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
Quinn sez (regarding use of MP APIs):

Did you call MPLibraryIsLoaded to check that MP was up and running 
before making this call?  MPLibraryIsLoaded is a macro that calls 
_MPIsFullyInitialized, which actually completes the initialisation of 
the MP library.  If you don't call it you get all sorts of weird 
errors.

Comment 1

15 years ago
Not that it isn't a good idea to initialize a library before using it :-) but 
Quinn's comment was in response to someone having problems using the MP APIs 
under Mac OS 9.2 which I believe we (currently) don't do.

Updated

15 years ago
Priority: -- → P1
Target Milestone: --- → 4.2
(Assignee)

Comment 2

15 years ago
Created attachment 75499 [details] [diff] [review]
Patch to call MPLibraryIsLoaded();

MPLibraryIsLoaded() is a macro that both tests the presence of the MP library,
and calls _MPIsFullyInitialized(). Since we only use the MP APIs on OS X, I
added the call to InitCriticalRegion() such that it only gets called on X.

Comment 3

15 years ago
Comment on attachment 75499 [details] [diff] [review]
Patch to call MPLibraryIsLoaded();

Do we really need to make this call on X?
(Assignee)

Comment 4

15 years ago
That's what the docs say. Of course, it may be a no-op on X, but there should be 
no harm in calling it, and that way we're following the API.

Comment 5

15 years ago
Comment on attachment 75499 [details] [diff] [review]
Patch to call MPLibraryIsLoaded();

r=wtc.

Can you get the drivers approval?
Attachment #75499 - Flags: review+

Updated

15 years ago
Blocks: 133659

Comment 6

14 years ago
This bug is in the Mac Classic version of NSPR.
Since we no longer support Mac Classic, marked
the bug WONTFIX even though we already have a
patch.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.