Last Comment Bug 123984 - Mac NSPR needs to call MPLibraryIsLoaded
: Mac NSPR needs to call MPLibraryIsLoaded
Product: NSPR
Classification: Components
Component: NSPR (show other bugs)
: other
: PowerPC Mac System 9.x
: P1 normal (vote)
: 4.2
Assigned To: Simon Fraser
: Wan-Teh Chang
Depends on:
Blocks: 133659
  Show dependency treegraph
Reported: 2002-02-06 15:34 PST by Simon Fraser
Modified: 2003-08-15 11:26 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch to call MPLibraryIsLoaded(); (846 bytes, patch)
2002-03-21 17:52 PST, Simon Fraser
wtc: review+
Details | Diff | Splinter Review

Description Simon Fraser 2002-02-06 15:34:23 PST
Quinn sez (regarding use of MP APIs):

Did you call MPLibraryIsLoaded to check that MP was up and running 
before making this call?  MPLibraryIsLoaded is a macro that calls 
_MPIsFullyInitialized, which actually completes the initialisation of 
the MP library.  If you don't call it you get all sorts of weird 
Comment 1 Steve Dagley 2002-02-06 15:54:01 PST
Not that it isn't a good idea to initialize a library before using it :-) but 
Quinn's comment was in response to someone having problems using the MP APIs 
under Mac OS 9.2 which I believe we (currently) don't do.
Comment 2 Simon Fraser 2002-03-21 17:52:04 PST
Created attachment 75499 [details] [diff] [review]
Patch to call MPLibraryIsLoaded();

MPLibraryIsLoaded() is a macro that both tests the presence of the MP library,
and calls _MPIsFullyInitialized(). Since we only use the MP APIs on OS X, I
added the call to InitCriticalRegion() such that it only gets called on X.
Comment 3 Wan-Teh Chang 2002-03-21 17:56:54 PST
Comment on attachment 75499 [details] [diff] [review]
Patch to call MPLibraryIsLoaded();

Do we really need to make this call on X?
Comment 4 Simon Fraser 2002-03-21 18:32:26 PST
That's what the docs say. Of course, it may be a no-op on X, but there should be 
no harm in calling it, and that way we're following the API.
Comment 5 Wan-Teh Chang 2002-03-21 18:42:31 PST
Comment on attachment 75499 [details] [diff] [review]
Patch to call MPLibraryIsLoaded();


Can you get the drivers approval?
Comment 6 Wan-Teh Chang 2003-08-15 11:26:37 PDT
This bug is in the Mac Classic version of NSPR.
Since we no longer support Mac Classic, marked
the bug WONTFIX even though we already have a

Note You need to log in before you can comment on or make changes to this bug.