1239872 - mach build faster fails with a traceback

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dave Townsend [:mossop]]

Attachment: log

I've made no changes to loop and yet mach build faster throws a traceback something in there.

Comment 1

[Mike Hommey [:glandium]]

This is a regression from bug 1232707, which added the following snippet to browser/extensions/loop/jar.mn:

  content/shared/vendor/         (chrome/content/shared/vendor/*)
#ifndef DEBUG
+ content/shared/vendor/react.js (chrome/content/shared/vendor/react-prod.js)

I'm going to make jar_maker reject this trick.

Comment 2

[Mike Hommey [:glandium]]

(for clarity, there is a react.js file in chrome/content/shared/vendor/, so what happens is that the jar maker copies react.js first, the overwrites it with react-prod.js. Since mach build faster uses install manifests for jar processing, it fails to handle this for good reasons.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Prevent jar maker from installing the same file twice

Comment 4

[Mark Banner (:standard8)]

Just to note the original issue has been fixed as a follow-up in bug 1232707.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Prevent jar maker from installing the same file twice

Turns out the previous patch broke the jar maker patch because the wildcard support was kind of broken in some way.

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Created attachment 8708294 [details] [diff] [review]
> Prevent jar maker from installing the same file twice
> 
> Turns out the previous patch broke the jar maker patch (...)

the jar maker test, is what I meant.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/077a27b3c91e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/077a27b3c91e