Closed Bug 1239879 Opened 8 years ago Closed 6 years ago

mozreview should do image diffs (or at least show added/removed images)

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: Gijs, Unassigned)

Details

Reviewing bug 1230638 ( https://reviewboard.mozilla.org/r/30945/diff/1#index_header ) is a pain right now. Just shows lots of "binary files" for all the pngs. :-(
Given the number of security exploits related to malformed images, what should be our policy on allowing the inline rendering of user-submitted images in MozReview? Right now anyone with an account can upload an image to a review request they create.
Flags: needinfo?(gdestuynder)
Flags: needinfo?(gdestuynder) → needinfo?(amuntner)
(In reply to :Gijs Kruitbosch from comment #0)
> Reviewing bug 1230638 (
> https://reviewboard.mozilla.org/r/30945/diff/1#index_header ) is a pain
> right now. Just shows lots of "binary files" for all the pngs. :-(

Review Board actually has the ability to do image diffs (it's hooked up for image file attachments). I believe most of the code for doing this in the diff viewer also exists, Review Board just hasn't hooked it up in a release because it hasn't been decided how to store / fetch the images from the repository.

We might be able to hook this up in our extensions since we only have to worry about Mozilla's repositories and can mandate a specific storage model.
What functionality would be lost by the alternatives: either no rendering or no user-submitted image uploading?
Flags: needinfo?(amuntner)
Product: Developer Services → MozReview
Just found this bug after reviewing a patch with a bunch of images: It would be incredible helpful to at least have a way to see the images / raw files (It doesn't even need to be inline if this is a matter of concern).
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.