Closed
Bug 1239911
Opened 8 years ago
Closed 8 years ago
Remove unnecessary codes in AudioStream.cpp
Categories
(Core :: Audio/Video: Playback, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bwu, Assigned: jwwang)
Details
Attachments
(1 file)
mAudioChannel[1] is not required anymore, we should remove it. Not sure if there are other unnecessary codes. The name of AudioChannel[2] is a little ambiguous. It would be better to call it "AudioChannelType". https://dxr.mozilla.org/mozilla-central/source/dom/media/AudioStream.cpp#326 https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-unknown-linux-gnu/dist/include/mozilla/dom/AudioChannelBinding.h#24
Updated•8 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43629/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43629/
Attachment #8736998 -
Flags: review?(bechen)
Updated•8 years ago
|
Attachment #8736998 -
Flags: review?(bechen) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8736998 [details] MozReview Request: Bug 1239911 - Remove unused |mAudioChannel|. r=bechen. https://reviewboard.mozilla.org/r/43629/#review40233
Assignee | ||
Comment 3•8 years ago
|
||
Thanks!
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jwwang
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3dbb54c784bf
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•