1239946 - Dispatch error when nsISpeechService.Speak returns error

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Makoto Kato [:m_kato]]

+++ This bug was initially created as a clone of Bug #1238522 +++

Related to bug 1238522.  Even if nsISpeechService.Speak() returns any error, there is no way whether current task status is error.

If it is indirect service, we should dispatch error.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Dispatch error event when nsISpeechService.Speak returns error

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Change test to return error on Speak method

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8708261 [details] [diff] [review]
Dispatch error event when nsISpeechService.Speak returns error

nsISpeechService.Speak can return error.  When returns error without dispatching error event, this task isn't removed from queue.

So I think that we should dispatch error if nsISpeechService.Speak returns error.  Because this is XPCOM and addon developer can implement it.

Also, I have no idea for direct audio yet.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8708262 [details] [diff] [review]
Change test to return error on Speak method

Change error case on mochitest

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8708261 [details] [diff] [review]
Dispatch error event when nsISpeechService.Speak returns error

Review of attachment 8708261 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webspeech/synth/nsSynthVoiceRegistry.cpp
@@ +793,5 @@
> +                                        aPitch, aTask))) {
> +    if (serviceType == nsISpeechService::SERVICETYPE_INDIRECT_AUDIO) {
> +      aTask->DispatchError(0, 0);
> +    }
> +    // XXX When using direct audio, no way to dispatch error

Seems like this should be possible no?

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Eitan Isaacson [:eeejay] from comment #5)
> Comment on attachment 8708261 [details] [diff] [review]
> Dispatch error event when nsISpeechService.Speak returns error
> 
> Review of attachment 8708261 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/media/webspeech/synth/nsSynthVoiceRegistry.cpp
> @@ +793,5 @@
> > +                                        aPitch, aTask))) {
> > +    if (serviceType == nsISpeechService::SERVICETYPE_INDIRECT_AUDIO) {
> > +      aTask->DispatchError(0, 0);
> > +    }
> > +    // XXX When using direct audio, no way to dispatch error
> 
> Seems like this should be possible no?

There is no way to dispatch error event from direct service implementation.  nsISpeechTask.sendAudioNative(buffer, 0) or nsISpeechTask.cancel() will dispatch end event, but it isn't error.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a86aa13dc19c
https://hg.mozilla.org/integration/mozilla-inbound/rev/9807e39dc5bc

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a86aa13dc19c
https://hg.mozilla.org/mozilla-central/rev/9807e39dc5bc