Change notification copy when someone joins a room

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
19
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: RT, Assigned: mancas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User Story

The current copy of the notification prompted when someone joins a room is:
Firefox Hello
Someone has joined the conversation!

This copy is now wrong because:
- We want to stop referring to conversations
- We want to have separate copies depending on whether the link generator is in the room or not (currently the notification copy is the same in both scenarios). If the link generator is in the conversation he needs to be made aware that the clicker now sees his tabs. If he is not in a conversation he needs to be aware that someone is waiting for him.

Proposal:
- When the link generator is not in the room
--- "Someone is waiting for you to browse <Room domain name> together."
- When the link generator is in the room
--- "Someone is now browsing <Room domain name> with you and can see your tabs

Attachments

(3 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
User Story: (updated)
(Reporter)

Comment 1

3 years ago
Hi Matej, can you please take a look and tell me what you think?
Flags: needinfo?(matej)
(Reporter)

Updated

3 years ago
Rank: 25
Priority: -- → P2

Comment 2

3 years ago
(In reply to Romain Testard [:RT] from comment #1)
> Hi Matej, can you please take a look and tell me what you think?

Can you clarify who will see these strings? Is it the link generator or the link clicker?
(Reporter)

Comment 3

3 years ago
This is a system notification displayed to the link generator when someone joins one of his rooms.

Comment 4

3 years ago
(In reply to Romain Testard [:RT PTO until Feb 1st] from comment #3)
> This is a system notification displayed to the link generator when someone
> joins one of his rooms.

The first one says "When the link generator is not in the room." Should that be "link clicker" instead of generator?
Flags: needinfo?(matej)
(Reporter)

Comment 5

3 years ago
(In reply to Matej Novak [:matej] from comment #4)
> (In reply to Romain Testard [:RT PTO until Feb 1st] from comment #3)
> > This is a system notification displayed to the link generator when someone
> > joins one of his rooms.
> 
> The first one says "When the link generator is not in the room." Should that
> be "link clicker" instead of generator?

No it's correct. When the link generator is not in the room he gets a notification telling him that someone joined one of his rooms so he knows that the link clicker is now waiting for him to join.
User Story: (updated)

Comment 6

3 years ago
OK, I think I understand now. How about these?

- When the link generator is not in the room
--- "Your friend is waiting to browse <Room domain name> with you."

- When the link generator is in the room
--- "Your friend is now browsing <Room domain name> with you and can see your tabs."

OR

--- "Your friend is now connected and will be able to see your tabs."
Rank: 25 → 24
Rank: 24 → 19
Priority: P2 → P1
(Assignee)

Updated

2 years ago
Assignee: nobody → b.mcb
(Assignee)

Comment 7

2 years ago
Created attachment 8712144 [details]
Owner not in the room
Attachment #8712144 - Flags: feedback?(matej)
(Assignee)

Comment 8

2 years ago
Created attachment 8712145 [details]
Owner in the room
Attachment #8712145 - Flags: feedback?(matej)
Created attachment 8712146 [details] [review]
[loop] mancas:bug1239978 > mozilla:master
(Assignee)

Comment 10

2 years ago
Comment on attachment 8712146 [details] [review]
[loop] mancas:bug1239978 > mozilla:master

Hey Mike, can you review this patch?

Thank you
Attachment #8712146 - Flags: review?(mdeboer)
Comment on attachment 8712146 [details] [review]
[loop] mancas:bug1239978 > mozilla:master

For comments, plz check the PR. Thanks!
Attachment #8712146 - Flags: review?(mdeboer) → review-
Comment on attachment 8712144 [details]
Owner not in the room

Can we just make it "mozilla.org" instead of "www.mozilla.org"? In all case I'd prefer to remove the "www."
Comment on attachment 8712145 [details]
Owner in the room

This one looks fine.
Attachment #8712145 - Flags: feedback?(matej) → feedback+
(Assignee)

Comment 14

2 years ago
Created attachment 8712588 [details]
Owner not in the room
Attachment #8712144 - Attachment is obsolete: true
Attachment #8712144 - Flags: feedback?(matej)
Attachment #8712588 - Flags: feedback?(matej)
(Assignee)

Comment 15

2 years ago
Comment on attachment 8712146 [details] [review]
[loop] mancas:bug1239978 > mozilla:master

Comments addressed. Ready for a new iteration

Thanks!
Attachment #8712146 - Flags: review- → review?(mdeboer)
Comment on attachment 8712146 [details] [review]
[loop] mancas:bug1239978 > mozilla:master

See the PR for comments. Thanks!
Attachment #8712146 - Flags: review?(mdeboer) → review+
Comment on attachment 8712588 [details]
Owner not in the room

Looks good. Thanks.
Attachment #8712588 - Flags: feedback?(matej) → feedback+
(Assignee)

Comment 18

2 years ago
Landed in master: https://github.com/mozilla/loop/commit/707be47ecb47cc4950b5fd93bc30d774a9deb78f

Thanks!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.