Closed Bug 1240056 Opened 7 years ago Closed 7 years ago

Disable anti-aliasing on desktop-test image

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: armenzg, Assigned: armenzg)

References

Details

Attachments

(1 file)

In bug 1239301 we noticed that the fonts on the releng hosts versus the docker image were slightly different and caused some test failures.
The difference is that on the releng host we have anti-aliasing disabled and many tests (reftests mainly) had adapted for this configuration, hence, failing if enabled.

In this bug we're going to disable anti-aliasing for the desktop-test image in order to pass the tests.

See the difference between the two pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=3c9a54d68c95,1d3078c86e52

We went from failing over 200 tests across jobs to less than 10-20 tests in total.
In bug 1239301 we noticed that the fonts on the releng Linux hosts versus the
docker image were slightly different and caused some test failures.
The difference is that on the releng hosts we have anti-aliasing disabled and
many tests (reftests mainly) had adapted for this configuration, hence, failing if enabled.

In this bug we're going to disable anti-aliasing for the desktop-test image in
order to pass the tests.

See the difference between the two pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=3c9a54d68c95,1d3078c86e52

We went from failing over 200 tests across jobs to less than 10-20 tests in total.

In the future we will have to consider if we want to fix this configuration.

Review commit: https://reviewboard.mozilla.org/r/31055/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31055/
Attachment #8708444 - Flags: review?(dustin)
Attachment #8708444 - Flags: review?(dustin) → review+
Comment on attachment 8708444 [details]
MozReview Request: Bug 1240056 - Disable anti-aliasing on desktop-test image. DONTBUILD. r=dustin

https://reviewboard.mozilla.org/r/31055/#review27877

::: testing/docker/desktop-test/Dockerfile:60
(Diff revision 1)
> +# Once we switch over we can disable it and fix the tests for it

This should probably indicate that it's specifically *font* anti-aliasing.  And we may not want to change this, so best not to put those plans in the source.. so maybe edit the comment, but the change itself looks good.
I fixed it.
Please let me know when the image is uploaded. Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/fefe66d4bc837c652d44b137cad7b420d51500ad
Bug 1240056 - Disable font anti-aliasing on desktop-test image. DONTBUILD. r=dustin
https://hg.mozilla.org/mozilla-central/rev/fefe66d4bc83
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.