Closed Bug 1240070 Opened 8 years ago Closed 8 years ago

Logspam in console mochitests - "hud.ui.webConsoleClient is null"

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox46 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox46 --- affected

People

(Reporter: bgrins, Assigned: linclark)

References

Details

Since Bug 1064458 I'm seeing some extra logging originating from the browser_console_netlogging.js test.  See this push for instance: https://treeherder.mozilla.org/#/jobs?repo=try&revision=83b56e102a18

TypeError: hud.ui.webConsoleClient is null: testResponse@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser_console_netlogging.js:31:3

Searching for that error in the raw log it seems that it's trying to execute code from the netlogging test even after it finishes: http://archive.mozilla.org/pub/firefox/try-builds/bgrinstead@mozilla.com-34d2924730ad046e1855c3e313145da41eb82578/try-linux/try_ubuntu32_vm_test-mochitest-devtools-chrome-8-bm01-tests1-linux32-build518.txt.gz.

I'm guessing this is because HUDService.lastFinishedRequest.callback is never reset after the test ends.  This cleanup seems like something that should be happening in head.js but at least for now we can set that to null when this test finishes.
Assignee: nobody → lclark
Status: NEW → ASSIGNED
I've added some registerCleanupFunction() calls in Bug 1234287. I think this should help. Let's check once that has landed.
No longer blocks: 1064458
Depends on: 1234287
I'm pretty sure this is resolved, so I'm going to close. 

Dear reader, if you landed on this bug because you're seeing the same thing, please reopen.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.