Closed Bug 1240082 Opened 4 years ago Closed 4 years ago

Remove ant requirement

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jchen, Unassigned)

References

Details

When I tried to remove the ant requirements as outlined in bug 1223209 comment 9, I ran into a build failure for the "api 11+ taskcluster (tier-2)" build, about not being able to find java:

> 20:51:13     INFO -  classes.dex
> 20:51:13     INFO -  /home/worker/workspace/build/src/android-sdk-linux/build-tools/23.0.1/dx --dex --output=classes.dex jars-proguarded
> 20:51:13     INFO -  /home/worker/workspace/build/src/android-sdk-linux/build-tools/23.0.1/dx: line 89: exec: java: not found
> 20:51:13     INFO -  gmake[5]: *** [classes.dex] Error 127
> 20:51:13     INFO -  gmake[5]: Leaving directory `/home/worker/workspace/build/src/obj-firefox/mobile/android/base'
> 20:51:13     INFO -  gmake[4]: *** [mobile/android/base/libs] Error 2
> 20:51:13     INFO -  gmake[4]: Leaving directory `/home/worker/workspace/build/src/obj-firefox'
> 20:51:13     INFO -  gmake[3]: *** [libs] Error 2
> 20:51:13     INFO -  gmake[3]: Leaving directory `/home/worker/workspace/build/src/obj-firefox'
> 20:51:13     INFO -  gmake[2]: *** [default] Error 2
> 20:51:13     INFO -  gmake[2]: Leaving directory `/home/worker/workspace/build/src/obj-firefox'
> 20:51:13     INFO -  gmake[1]: *** [realbuild] Error 2
> 20:51:13     INFO -  gmake[1]: Leaving directory `/home/worker/workspace/build/src'
> 20:51:13     INFO -  gmake: *** [build] Error 2
> 20:51:13     INFO -  450 compiler warnings present.
> 20:51:14     INFO -  Notification center failed: Install the python dbus module to get a notification when the build finishes.
> 20:51:14    ERROR - Return code: 2
> 20:51:14  WARNING - setting return code to 2
jchen: can you link to the try build?  This might be a path issue with the ant package winning over the (badly configured) open JDK package in https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/tooltool-manifests/b2gdroid/releng.manifest#55.
Flags: needinfo?(nchen)
dustin: I recall you futzing around with the OpenJDK packages and paths to Java.  Can't recall what the outcome was, though.  After jchen links the try build, could you comment on what might be happening above?
Flags: needinfo?(dustin)
(In reply to Nick Alexander :nalexander from comment #1)
> jchen: can you link to the try build?  This might be a path issue with the
> ant package winning over the (badly configured) open JDK package in
> https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/
> tooltool-manifests/b2gdroid/releng.manifest#55.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9e43ad13d42

My patch did remove these two lines from mobile/android/config/mozconfigs/common:

> mk_add_options "export ANT_HOME=$topsrcdir/apache-ant"
> mk_add_options "export PATH=$topsrcdir/apache-ant/bin:$PATH"
Flags: needinfo?(nchen)
I suspect it's the latter of those two mk_add_options removals that did it.  `dx` expects to find `java` in PATH, and on TC that's under $topsrcdir (although not in $topsrcdir/apache-ant.. maybe that's a symlink? dunno..)

Specifically,

{
"size": 31013068,
"visibility": "public",
"digest": "e30a26f98a3448064857491aee1a7a26f98494f86a89113de9be17c37c8181ed60250706fed881ec1f035002fcdaf8b9b4a7d9ae70ce40acff2f1acfbb40f8d9",
"algorithm": "sha512",
"filename": "java_home-1.7.0-openjdk-1.7.0.85.x86_64.tar.xz",
"unpack": true
}

gets unpacked as $topsrcdir/java_home, and that gets added to PATH here:

./mobile/android/config/mozconfigs/common:    export PATH="$PATH:$topsrcdir/java_home/bin"

did that get removed as well?
Flags: needinfo?(dustin)
Gah, posted to wrong ticket: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bde613397c4e

Looks like the conditional path wankery at the top of the mozconfig bit me.  I'll see about making the mk_add_options conditional too.
https://hg.mozilla.org/mozilla-central/rev/3e880d2651f9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 46 → mozilla46
You need to log in before you can comment on or make changes to this bug.