1240083 - remove eq_ and ok_

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

As part of bug #1239830 converting from nose to py.test, I implemented eq_ and ok_ in kuma.core.tests and changed alllllllll the test files to import those. I did that instead of changing the 1200 or so instances of eq_ usage figuring it was easier to do and review that work in small code cleanup passes.

This bug covers doing that work.

The work entails something like:

1. remove "from kuma.core.tests import eq_, ok_" and similar imports from the top

2. go through and convert all:

      eq_(first, second)

   to:

      assert first == second

3. go through and convert all:

      ok_(val)

   to one of the following depending on what val might be:

      assert val
      assert val == True

4. run the tests and make sure everything continues to work


After we're done, then we can remove eq_ and ok_ definitions from kuma/core/tests/__init__.py.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f24bf32fea4a067536afd0ea4a232d0667da4679
bug 1240083: Remove ok_() from tests

The `ok_()` function is a reliquat of the transition from nose to
pytest.

It does not provide anything except clutter for the current codebase.

This commit removes all references to `ok_()` and replace it with
`assert`

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/dd777e5d923c44f9f3f1168dc30beda55d7ad4dc
bug 1240083: Remove eq_() from tests

The `eq_()` function is a reliquat of the transition from nose to
pytest.

It does not provide anything except clutter for the current codebase.

This commit removes all references to `eq_()` and replace it with
`assert`

https://github.com/mozilla/kuma/commit/599c868b0dfb94a916f950e038f74627089f2028
Merge pull request #4869 from MatonAnthony/1240083-remove-eq

bug 1240083: Remove eq_() from tests

Comment 3

[John Whitlock [:jwhitlock]]

ok_ and eq_ are now gone. Thanks Anthony!