compare vew filter misses many characters due to filtering on each keypress

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jmaher, Assigned: parkouss)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
when looking at a compare view, I type 'paint' and get 'pa', or sometimes a random other character.  This seems to be filtering for each keypress, we should optimize this if possible.
:parkouss did something similar to the test chooser, see bug 1227249

Comment 2

2 years ago
Created attachment 8711653 [details] [review]
[treeherder] parkouss:compare-filter-debounce > mozilla:master
(Assignee)

Comment 3

2 years ago
Comment on attachment 8711653 [details] [review]
[treeherder] parkouss:compare-filter-debounce > mozilla:master

This is the same trick used for test selection. Not perfect, but a lot better. :)
Attachment #8711653 - Flags: review?(wlachance)
(Assignee)

Updated

2 years ago
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Comment on attachment 8711653 [details] [review]
[treeherder] parkouss:compare-filter-debounce > mozilla:master

Awesome, thanks! The test filtering dialog might get a substantial overhaul in the weeks ahead, so a simple solution is perfect here.
Attachment #8711653 - Flags: review?(wlachance) → review+
Keywords: autoland

Comment 5

2 years ago
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/34a86b8843f6740600b787c166a9e9ccb6265393

Updated

2 years ago
Keywords: autoland

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.