Closed
Bug 1240148
Opened 10 years ago
Closed 10 years ago
modify docs so it's clear we don't accept translation prs
Categories
(developer.mozilla.org Graveyard :: Localization, defect)
developer.mozilla.org Graveyard
Localization
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
Recently, we switched from an external svn holding all translated strings to having the strings in the kuma repository alongside the code. This was a great day--there was much rejoicing.
Yayyy!
However, this makes it possible for translators to translate the strings and submit a PR in github.
There are a lot of problems with this workflow:
1. we lack the expertise to review that
2. if we don't review and merge it quickly, it can get out of date
3. it skips over the review workflow, permissions, validation and other magic of Pontoon
4. this will likely make locale communities and the l10n team cross
Given that, we shouldn't accept PRs for translations.
This bug covers updating CONTRIBUTE.md and the localization documentation to make this clear.
| Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/00e24ee5c3464bb7e346648f4c63d0dfb1c86768
Fix bug 1240148: Fix docs regarding translation prs
We can't accept translation changes in pull requests. All translation
changes should happen through Pontoon.
These changes make that clearer.
https://github.com/mozilla/kuma/commit/bb078fe4a50ecf9af69b26ce6861c98df61b56e7
Merge pull request #3758 from mozilla/1240148-l10n
Fix bug 1240148: Fix docs regarding translation prs
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•