1240165 - eslint mark-test-function-used rule does not work for xpcshell

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Tom Tromey :tromey]

The eslint mark-test-function rule does not work for xpcshell tests,
but should.  Currently it only works for browser mochitests.

To work for xpcshell tests it should look for a file named test_*.js
and it should mark the function "run_test" as used.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree.

Review commit: https://reviewboard.mozilla.org/r/88564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88564/

Comment 2

[Mark Banner (:standard8)]

Note: these changes resolves 941 no-unused-vars errors out of 3955ish when no-unused-vars is turned on in the toolkit eslint.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8804651 [details]
Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88564/diff/1-2/

Comment 4

[Mark Banner (:standard8)]

The update I've just pushed includes removal of a few places where run_test was being exported or handled especially.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8804651 [details]
Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree.

https://reviewboard.mozilla.org/r/88564/#review88696

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/141c1a49b1b1
Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree. r=miker

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/141c1a49b1b1