widget/nsShmImage.h:64:20: error: unknown type name 'LayoutDeviceIntRegion'; did you mean 'mozilla::LayoutDeviceIntRegion'?

RESOLVED FIXED in Firefox 46

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

Build error that I hit locally today:
{
18:04.66 In file included from ../../../mozilla/widget/gtk/nsWindow.cpp:124:
18:04.66 ../../../mozilla/widget/nsShmImage.h:64:20: error: unknown type name 'LayoutDeviceIntRegion'; did you mean 'mozilla::LayoutDeviceIntRegion'?
18:04.66              const LayoutDeviceIntRegion& aRegion);
18:04.66                    ^~~~~~~~~~~~~~~~~~~~~
18:04.66                    mozilla::LayoutDeviceIntRegion

}

This seems to have been an oversight in bug 1239530 (which added the line of code in question).  Every "LayoutDeviceXYZ" usage that it added in this file was mozilla::-prefixed, except for this one:
 http://hg.mozilla.org/mozilla-central/rev/8cdc38ea4f6d#l16.2

I'm guessing we didn't hit this on treeherder because we picked up a
  typedef mozilla::LayoutDeviceIntRegion LayoutDeviceIntRegion;
from some other .h or .cpp file, via unified builds (but my local unified-build grouping happens to work out differently, maybe due to mozconfig differences).
Here's the fix, just adding "mozilla::".
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8708637 - Flags: review?(n.nethercote)
Attachment #8708637 - Attachment description: fix v1 → fix v1 (just add "mozilla::" as with other LayoutDeviceXYZ usages in this file)
Comment on attachment 8708637 [details] [diff] [review]
fix v1 (just add "mozilla::" as with other LayoutDeviceXYZ usages in this file)

Review of attachment 8708637 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the fix. The other option would be to introduce typedefs:

    typedef mozilla::LayoutDeviceIntRegion LayoutDeviceIntRegion;
    typedef mozilla::LayoutDeviceIntSize LayoutDeviceIntSize;

and removing the prefixes where appropriate. I'll let you decide.
Attachment #8708637 - Flags: review?(n.nethercote) → review+
Thanks! I'll just stick with the patch that I've got -- we can always add a typedef & remove the prefixes later if we like.
https://hg.mozilla.org/mozilla-central/rev/32178f8eb397
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.