Closed Bug 1240262 Opened 4 years ago Closed 4 years ago

Annotate intentional switch fallthrough and suppress -Wimplicit-fallthrough warnings in dom/canvas/

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

MurmurHash3.cpp is third-party code, so I suppressed the -Wimplicit-fallthrough warnings in moz.build instead of patching the file.
Attachment #8708659 - Flags: review?(gwright)
dom/canvas/WebGL2ContextState.cpp:116:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/canvas/MurmurHash3.cpp:140:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
Comment on attachment 8708659 [details] [diff] [review]
dom-canvas-MOZ_FALLTHROUGH.patch

Not really my domain. Jeff's a better reviewer for this.
Attachment #8708659 - Flags: review?(gwright) → review?(jgilbert)
Attachment #8708659 - Flags: review?(jgilbert) → review+
Thanks, Jeff!
https://hg.mozilla.org/mozilla-central/rev/498713f322b1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.