12403 - border-style: hidden should force border-width: 0

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION: You have already (almost a year ago) made it so border-style: none
forces border-width to 0.  However, the CSS2 border-style: hidden is the same as
none everywhere except tables.  However, it's not forcing border-width to 0.

STEPS TO REPRODUCE:  Load attached test case.

ACTUAL RESULTS:  Second line is indented.

EXPECTED RESULTS:  It should not be indented

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-08-20-13-M10

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test case described in bug

Comment 2

[troy]

Peter, I changed the CSS rendering code to treat NS_STYLE_BORDER_STYLE_HIDDEN
just like NS_STYLE_BORDER_STYLE_NONE and I'll check that in.

It looks like several places in the style code need to change including
RecalcData(). I'll leave that to you

When you're done please assign this to Chris so he can make sure that tables are
changed accordingly

Comment 3

[Peter Linss]

Moving non-beta 1 items to M15

Comment 4

[Pierre Saslawsky]

Reassigning peterl's bugs to myself.

Comment 5

[Pierre Saslawsky]

Accepting peterl's bugs that have a Target Milestone

Comment 6

[Pierre Saslawsky]

Pushing my M15 bugs to M16

Comment 7

[Hixie (not reading bugmail)]

Migrating from {css2} to css2 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...

Comment 8

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 9

[Pierre Saslawsky]

Pushing again: M18.

Comment 10

[ekrock's old account (dead)]

Nom. nsbeta3, recc. nsbeta3+. Impacts correctness of positioning of text in CSS 
box model. Looks like this is a matter of rolling out to a few more places in 
the code a fix that was already done elsewhere. 

Comment 11

[Pierre Saslawsky]

Marking nsbeta2/fix in hand, it's better than "future" ;-P
CCd attinasi for review.

Comment 12

[Pierre Saslawsky]

Attachment: patch

Comment 13

[Marc Attinasi]

The patch looks excellent. I would have named it IsBorderSideVisible instead of 
IsVisibleBorderSide but maybe that is just preference... you got my r=.

So, should we get this in now so karnaze can use it in his collapsed border 
model implementation, or doesn't it matter for him?

Comment 14

[leger]

Putting on [nsbeta2+] radar.  Patch appears low risk. Approved to checkin for 
patch as shown.

Comment 15

[Sebastian Späth]

Adding PATCH keyword for easier querying.

Comment 16

[Pierre Saslawsky]

Fix checked in nsStyleContext.cpp

Comment 17

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- MacOS9 2000-06-30-09-M17 Commercial
- Linux6 2000-06-30-08-M17 Commercial
- Win98  2000-06-30-09-M17 Commercial