Closed Bug 1240373 Opened 4 years ago Closed 4 years ago

Wrong findBar background color in Chat tab

Categories

(Thunderbird :: Theme, defect)

All
Windows
defect
Not set

Tracking

(thunderbird45 fixed, thunderbird46 fixed)

RESOLVED FIXED
Thunderbird 46.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

On XP (white background) and Win8/10 (light blue background) the findBar background color is wrong comparing to the message tab (-moz-Dialog background).
Attached patch chatColor.patch (obsolete) — Splinter Review
Changed the background-color for #conversationsDeck.

Windows is special against Linux and OSX because #messengerWindow is used to set the titlebar background color. This needs a background-color definition on a children to set the correct color.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8708791 - Flags: review?(aleth)
Comment on attachment 8708791 [details] [diff] [review]
chatColor.patch

Review of attachment 8708791 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/windows/mail/chat.css
@@ +24,5 @@
>    border: none;
>  }
>  
>  #conversationsDeck {
> +  background: -moz-Dialog;

Does this affect the look of the chat tab when no accounts are connected? (and if it does, is that correct too?)
It doesn't affect the #noConvScreen as it's background color is set here: https://dxr.mozilla.org/comm-central/source/mail/themes/windows/mail/chat.css#545 I'm seeing now there is a space too much. Okay, when I fix this in this bug?
(In reply to Richard Marti (:Paenglab) from comment #3)
> It doesn't affect the #noConvScreen as it's background color is set here:
> https://dxr.mozilla.org/comm-central/source/mail/themes/windows/mail/chat.
> css#545 I'm seeing now there is a space too much. Okay, when I fix this in
> this bug?

Sure, thanks!
Attachment #8708791 - Flags: review?(aleth) → review+
Attached patch chatColor.patchSplinter Review
Fixed the whitespace issue. Crying over the r+
Attachment #8708791 - Attachment is obsolete: true
Attachment #8708819 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8708819 [details] [diff] [review]
chatColor.patch

[Approval Request Comment]
User impact if declined: wrong finbar background color
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low, only CSS changes
Attachment #8708819 - Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Attachment #8708819 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.