1240391 - click on button 'get next X jobs' adds a duplicate results check as interval

Status: RESOLVED FIXED

Description

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Clicking on a button at the bottom of treeherder to get the next 10/20/50 pushes adds another periodic check for new results (and every additional click will add one more). All these requests have the same url, e.g. https://treeherder.mozilla.org/api/project/mozilla-inbound/jobs/?count=2000&last_modified__gt=2016-01-17T17:15:00.000&result_set_id__in=25321,25320,25319,25318,25317,25316,25315,25314,25313,25312,25311,25310,25309,25308,25307,25306,25305,25304,25303,25302,25301,25300,25299,25298,25297,25296,25295,25294,25293,25292,25291&return_type=list

Comment 1

[GitHub Autolander Bot]

Created attachment 8708829 [details] [review]
[treeherder] Archaeopteryx:bug1240391-updateIntervalAppend > mozilla:master

Comment 2

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Created attachment 8708830 [details] [review]
pull request, v1

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8708830 [details] [review]
pull request, v1

Good spot and thank you for the PR. Cameron knows this code better than I, so redirecting :-)

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8708830 [details] [review]
pull request, v1

Made a note in the PR, but this change would have the effect that clicking a "next" button would load more resultsets with no jobs.

I'm actually not able to reproduce the problem you're referring to.  I only see 1 call to the /resultsets/ endpoint per poll interval no matter how many times I click a "next X" button.  We DO add more /jobs/ endpoint pollers because we have to have a poller for each resultset to get any new jobs that have been created.

Would you be able to provide more information on what you're seeing?  Thanks!  :)

Comment 5

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

When I open https://treeherder.mozilla.org and let the page idle, the web console shows two requests repeating once per minute:

https://treeherder.mozilla.org/api/project/mozilla-inbound/resultset/?fromchange=52d3e5be2dbc

https://treeherder.mozilla.org/api/project/mozilla-inbound/jobs/?count=2000&last_modified__gt=2016-01-22T18:46:34.000&result_set_id__in=25661,25660,25659,25658,25657,25656,25655,25654,25653,25652&return_type=list

After clicking the "get next 10 jobs" button, I see two job requests per minute:

https://treeherder.mozilla.org/api/project/mozilla-inbound/jobs/?count=2000&last_modified__gt=2016-01-22T18:53:47.000&result_set_id__in=25661,25660,25659,25658,25657,25656,25655,25654,25653,25652,25651,25650,25649,25648,25647,25646,25645,25644,25643,25642&return_type=list

https://treeherder.mozilla.org/api/project/mozilla-inbound/jobs/?count=2000&last_modified__gt=2016-01-22T18:54:36.000&result_set_id__in=25661,25660,25659,25658,25657,25656,25655,25654,25653,25652,25651,25650,25649,25648,25647,25646,25645,25644,25643,25642&return_type=list

When I investigated regressions last Saturday, I used the button several times and noticed later that the idle treeherder page was downloading MB/min.

Comment 6

[Cameron Dawson [:camd]]

ahh, ok. So it looks like the issue is that it's duplicating the job pollers.  Yeah, I'm seeing that too.  Perhaps a check needs to be added to see if there is already a job poller and not add a anew one in that case.  You may not need your param at all.

Comment 7

[GitHub Autolander Bot]

Created attachment 8714399 [details] [review]
[treeherder] Archaeopteryx:bug1240391-updateIntervalAppend > mozilla:master

Comment 8

[Cameron Dawson [:camd]]

Comment on attachment 8714399 [details] [review]
[treeherder] Archaeopteryx:bug1240391-updateIntervalAppend > mozilla:master

Nice!  This works great!  Thanks for the patch.  :)

Comment 9

[Treeherder Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d1d213ac770355fbb8c67abf572169e2dac4ab44
Bug 1240391 - 'Get next X jobs' shouldn't create additional job pulling interval

https://github.com/mozilla/treeherder/commit/937fba1a2da220c8f738b1127773fe653fead1dd
Merge pull request #1289 from Archaeopteryx/bug1240391-updateIntervalAppend

Bug 1240391 - 'Get next X jobs' shouldn't create additional job pulling interval