Closed
Bug 1240411
Opened 8 years ago
Closed 8 years ago
Cleanup dom/media header declarations
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(10 files)
91.92 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
25.72 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
9.25 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
18.12 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
88.40 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
18.16 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
18.28 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
14.58 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
103.72 KB,
patch
|
jwwang
:
review+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
Lots of redundant virtual keyword or missing override.
Assignee | ||
Comment 1•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Attachment #8708865 -
Flags: review?(karlt)
Assignee | ||
Comment 2•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Attachment #8708866 -
Flags: review?(rjesup)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8708867 -
Flags: review?(cpearce)
Assignee | ||
Comment 4•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Attachment #8708868 -
Flags: review?(cpearce)
Assignee | ||
Comment 5•8 years ago
|
||
Remove redundant virtual keywords
Attachment #8708869 -
Flags: review?(cpearce)
Assignee | ||
Comment 6•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Assignee | ||
Comment 7•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Attachment #8708873 -
Flags: review?(giles)
Assignee | ||
Comment 8•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Attachment #8708874 -
Flags: review?(cpearce)
Assignee | ||
Comment 9•8 years ago
|
||
Remove redundant virtual keyword and add missing override if any.
Attachment #8708875 -
Flags: review?(jwwang)
Assignee | ||
Updated•8 years ago
|
Attachment #8708872 -
Flags: review?(ayang)
Comment 10•8 years ago
|
||
Comment on attachment 8708875 [details] [diff] [review] P9. Clean up media headers. Review of attachment 8708875 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/MediaManager.cpp @@ +794,4 @@ > AudioConfig(bool aEchoOn, uint32_t aEcho, > bool aAgcOn, uint32_t aAgc, > bool aNoiseOn, uint32_t aNoise, > int32_t aPlayoutDelay) missing 'override'? ::: dom/media/MediaStreamGraph.cpp @@ +1796,5 @@ > > class Message : public ControlMessage { > public: > explicit Message(MediaStream* aStream) : ControlMessage(aStream) {} > + void Run() missing 'override'? @@ +1803,5 @@ > auto graph = mStream->GraphImpl(); > mStream->DestroyImpl(); > graph->RemoveStreamGraphThread(mStream); > } > + void RunDuringShutdown() missing 'override'?
Attachment #8708875 -
Flags: review?(jwwang) → review+
Assignee | ||
Comment 11•8 years ago
|
||
(In reply to JW Wang [:jwwang] from comment #10) > Comment on attachment 8708875 [details] [diff] [review] > P9. Clean up media headers. > > Review of attachment 8708875 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/media/MediaManager.cpp > @@ +794,4 @@ > > AudioConfig(bool aEchoOn, uint32_t aEcho, > > bool aAgcOn, uint32_t aAgc, > > bool aNoiseOn, uint32_t aNoise, > > int32_t aPlayoutDelay) > > missing 'override'? I can't find an AudioConfig method to override: this is GetUserMediaCallbackMediaStreamListener that inherits from MediaStreamListener. I'm not familiar with that part of the code though. > > ::: dom/media/MediaStreamGraph.cpp > @@ +1796,5 @@ > > > > class Message : public ControlMessage { > > public: > > explicit Message(MediaStream* aStream) : ControlMessage(aStream) {} > > + void Run() > > missing 'override'? thanks ! I knew I had missed one after I had pressed "next find" too quickly, but couldn't find it after that :)
Updated•8 years ago
|
Attachment #8708872 -
Flags: review?(ayang) → review+
Assignee | ||
Comment 12•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8708892 -
Flags: review?(ayang)
Updated•8 years ago
|
Attachment #8708892 -
Flags: review?(ayang) → review+
Assignee | ||
Comment 13•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9ed2680b361
Updated•8 years ago
|
Attachment #8708867 -
Flags: review?(cpearce) → review+
Updated•8 years ago
|
Attachment #8708868 -
Flags: review?(cpearce) → review+
Updated•8 years ago
|
Attachment #8708869 -
Flags: review?(cpearce) → review+
Updated•8 years ago
|
Attachment #8708874 -
Flags: review?(cpearce) → review+
Updated•8 years ago
|
Attachment #8708873 -
Flags: review?(giles) → review+
Assignee | ||
Comment 14•8 years ago
|
||
Comment on attachment 8708865 [details] [diff] [review] P1. Clean up webaudio headers. If Karl is away this week, could you look into doing it instead? it's the same stuff as all the other patches.
Attachment #8708865 -
Flags: review?(cpearce)
Updated•8 years ago
|
Attachment #8708865 -
Flags: review?(cpearce) → review+
Updated•8 years ago
|
Attachment #8708866 -
Flags: review?(rjesup) → review+
Comment 15•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/acd58a0c5b9c https://hg.mozilla.org/integration/mozilla-inbound/rev/15a9f1af28dc https://hg.mozilla.org/integration/mozilla-inbound/rev/f919ed5ef2c9 https://hg.mozilla.org/integration/mozilla-inbound/rev/8a7c295f149a https://hg.mozilla.org/integration/mozilla-inbound/rev/48d96340d424 https://hg.mozilla.org/integration/mozilla-inbound/rev/e1f4f479595d https://hg.mozilla.org/integration/mozilla-inbound/rev/96ac450beb52 https://hg.mozilla.org/integration/mozilla-inbound/rev/a43cba50892e https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e790bd76e4 https://hg.mozilla.org/integration/mozilla-inbound/rev/048b9519ef89
Assignee | ||
Updated•8 years ago
|
Attachment #8708865 -
Flags: review?(karlt)
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/acd58a0c5b9c https://hg.mozilla.org/mozilla-central/rev/15a9f1af28dc https://hg.mozilla.org/mozilla-central/rev/f919ed5ef2c9 https://hg.mozilla.org/mozilla-central/rev/8a7c295f149a https://hg.mozilla.org/mozilla-central/rev/48d96340d424 https://hg.mozilla.org/mozilla-central/rev/e1f4f479595d https://hg.mozilla.org/mozilla-central/rev/96ac450beb52 https://hg.mozilla.org/mozilla-central/rev/a43cba50892e https://hg.mozilla.org/mozilla-central/rev/a8e790bd76e4 https://hg.mozilla.org/mozilla-central/rev/048b9519ef89
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•