Closed Bug 1240417 Opened 4 years ago Closed 4 years ago

Encapsulate pointer arithmetic for AudioStream

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

Low level pointer arithmetic is error-prone. We will provide helper classes to encapsulate pointer arithmetic and boundary check to avoid buffer overwrite.
Comment on attachment 8708887 [details]
MozReview Request: Bug 1240417. Part 1 - add a writer class to encapsulate pointer arithmetic. r=kinetik.

https://reviewboard.mozilla.org/r/31169/#review28187
Attachment #8708887 - Flags: review?(kinetik) → review+
Attachment #8708888 - Flags: review?(kinetik) → review+
Comment on attachment 8708888 [details]
MozReview Request: Bug 1240417. Part 2 - remove unused code. r=kinetik.

https://reviewboard.mozilla.org/r/31171/#review28189
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/2cf303fd07fe
https://hg.mozilla.org/mozilla-central/rev/eb6c1e9ce81b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.