1240492 - [Static Analysis][Structurally dead code] In function ClosingService::AttachIOLayer from ClosingService.cpp

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that dead code is present after return NS_OK:

>>// static
>>nsresult
>>ClosingService::AttachIOLayer(PRFileDesc *aFd)
>>{
>>  // We are going to remove ClosingService soon.
>>  // This change is going to turn it off, so ClosingService is not used.
>>  // Bug 1238010.
>>  return NS_OK;
>>
>>  if (!sTcpUdpPRCloseLayerMethodsPtr) {
>>    return NS_OK;
>>  }
>>
>>  PRFileDesc * layer;
>>  PRStatus     status;
>>
>>  layer = PR_CreateIOLayerStub(sTcpUdpPRCloseLayerId,
>>                               sTcpUdpPRCloseLayerMethodsPtr);
>>
>>  if (!layer) {
>>    return NS_OK;
>>  }
>>
>>  ClosingLayerSecret *secret = new ClosingLayerSecret(sInstance);
>>  layer->secret = reinterpret_cast<PRFilePrivate *>(secret);
>>
>>  status = PR_PushIOLayer(aFd, PR_NSPR_IO_LAYER, layer);
>>
>>  if (status == PR_FAILURE) {
>>    delete secret;
>>    PR_DELETE(layer);
>>  }
>>  return NS_OK;
>>}

We should remove the dead code, in the future if we consider that we need it we can always rollback the file.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1240492 - remove dead code. r?mcmanus

Review commit: https://reviewboard.mozilla.org/r/31217/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31217/

Comment 2

[Dragana Damjanovic [:dragana]]

This is going away all together.
The code looks like this so that we can uplift it to aurora and beta. (when we return from that function earlier all ClosingService is actually not used, that is what we wanted)

Bug 1238017 - it is already in inbound but not central