Closed
Bug 1240493
Opened 8 years ago
Closed 8 years ago
[Stingray][fling-player][TV][2.5] Update video backward/forward searching time
Categories
(Firefox OS Graveyard :: Gaia::TV::Fling, defect, P1)
Firefox OS Graveyard
Gaia::TV::Fling
Tracking
(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
rexboy
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
The updated video backward/forward searching time: - long press <= 3000ms: 5 secs - 3000ms < long press <= 6000ms: 10 secs - long press > 6000ms: 30 secs
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → fliu
Updated•8 years ago
|
QA Whiteboard: [COM=TV Seamless Experience]
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → affected
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8708999 [details] [review] [gaia] Fischer-L:bug_1240493-update-fling-player-search-time > mozilla-b2g:master @Rex, This patch updates video backward/forward searching time on key press as below: - long key press <= 3000ms: 5 secs - 3000ms < long key press <= 6000ms: 10 secs - long key press > 6000ms: 30 secs Thank you
Attachment #8708999 -
Flags: review?(rexboy)
Comment 3•8 years ago
|
||
Comment on attachment 8708999 [details] [review] [gaia] Fischer-L:bug_1240493-update-fling-player-search-time > mozilla-b2g:master Looks good to me with 1 nit. See Github comment.
Attachment #8708999 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Land to master: https://github.com/mozilla-b2g/gaia/commit/619766a1ce78d50fb8a3b5a9e0821c335a0ed7ee Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e524997134772558af0c48084f3e95f1e373a52f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8708999 [details] [review] [gaia] Fischer-L:bug_1240493-update-fling-player-search-time > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1240493 [User impact] if declined: User would feel difficult to control video backward/forward searching time [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: None
Attachment #8708999 -
Flags: approval-gaia-v2.5?(jocheng)
Comment 6•8 years ago
|
||
Comment on attachment 8708999 [details] [review] [gaia] Fischer-L:bug_1240493-update-fling-player-search-time > mozilla-b2g:master Approve for TV 2.5
Attachment #8708999 -
Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
Updated•8 years ago
|
blocking-b2g: --- → 2.5+
Comment 7•8 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/ecb589094001e41a6f98092069050209196e789a
Target Milestone: --- → 2.6 S6 - 1/29
You need to log in
before you can comment on or make changes to this bug.
Description
•