1240523 - Fix puppet steps that run unnecessarily

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Some of the puppet steps run every time when they do not need to. eg the varnish port change and the addition of the Python2.7 PPA.

The latter made things harder to tapesh than it needed to be, since he couldn't just run the command manually himself and then re-provision, since the add-apt-repository still failed and so cause the provision to end early.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:puppet-cleanup > mozilla:master

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:puppet-cleanup > mozilla:master

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b7a93c02b30e6932a91f95dd0c9fc3621eae633c
Bug 1240523 - Vagrant: Don't update the varnish port on every provision

Also gives the exec command a more friendly name (instead of combining
the name and command) and removes the unnecessary multi-distro handling.

https://github.com/mozilla/treeherder/commit/c8911cf4aeac639befaa15785e843f7eb1051657
Bug 1240523 - Vagrant: Don't run add-apt-repository on every provision

Once the PPA has been added to the sources list there is no need to
run it again.

https://github.com/mozilla/treeherder/commit/7241e5c8c54818061668ece48b144770e03b6fb6
Bug 1240523 - Vagrant: Remove distro-specific code & deadcode

We only ever run this on Ubuntu (and the Heroku containers run Ubuntu
too) so let's drop support for other distros.