1240581 - Create marionette js test that checks the contents of the info view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[No-Jun Park [:njpark]]

Currently there is no test that checks whether the info view displays the data correctly.  This would also require adding Info_View class as well.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1240581 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8709258 [details] [review]
[gaia] npark-mozilla:1240581 > mozilla-b2g:master

This is the test that checks the displayed values of the video app.  Punam, do you know who else should I send the review request to? Thanks!

Comment 3

[Punam Dahiya [:pdahiya]]

(In reply to No-Jun Park [:njpark] from comment #2)
> Comment on attachment 8709258 [details] [review]
> [gaia] npark-mozilla:1240581 > mozilla-b2g:master
> 
> This is the test that checks the displayed values of the video app.  Punam,
> do you know who else should I send the review request to? Thanks!

Thanks No-Jun for the tests, we can use similar tests in gallery app. Please include russn for video specific review.

Comment 4

[Punam Dahiya [:pdahiya]]

Comment on attachment 8709258 [details] [review]
[gaia] npark-mozilla:1240581 > mozilla-b2g:master

Hi No-Jun,

Patch looks good, few nits noted in PR, with those fixed patch looks good to land. Thanks!

Comment 5

[Russ Nicoletti [:russn]]

Comment on attachment 8709258 [details] [review]
[gaia] npark-mozilla:1240581 > mozilla-b2g:master

Thanks for the patch, No-Jun. It looks good, although I have some concerns about possible timing issues. My comments are in the PR (sorry for all the nits!). Please flag me for review again when the PR is updated.

Comment 6

[No-Jun Park [:njpark]]

Comment on attachment 8709258 [details] [review]
[gaia] npark-mozilla:1240581 > mozilla-b2g:master

Hi Russ, I incorporated your suggestions here.  could you review again?  thanks!

Comment 7

[Russ Nicoletti [:russn]]

Comment on attachment 8709258 [details] [review]
[gaia] npark-mozilla:1240581 > mozilla-b2g:master

r+, with a couple of comments. Thanks, No-Jun.

Comment 8

[No-Jun Park [:njpark]]

(In reply to Russ Nicoletti [:russn] from comment #7)
> Comment on attachment 8709258 [details] [review]
> [gaia] npark-mozilla:1240581 > mozilla-b2g:master
> 
> r+, with a couple of comments. Thanks, No-Jun.

Thanks! I'll make the changes you mentioned in the comment.

Comment 9

[No-Jun Park [:njpark]]

Merged: 
https://github.com/mozilla-b2g/gaia/commit/0433a25e310189e37cb5ec813617c40bb6b02bb8