Remove unnecessary -Wno-uninitialized from dom/bindings

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8709148 [details] [diff] [review]
remove-Wno-uninitialized-from-dom-bindings.patch

Bug 831879 disabled -Wuninitialized warnings in dom/bindings. This is no longer necessary because the tree is now -Wuninitialized clean (bug 1001975).

gcc's -Wuninitialized historically had a well-deserved reputation for reporting false positives. In 2011 [1], gcc has separated -Wuninitialized's less reliable checks into a new -Wmaybe-uninitialized warning. gcc's and clang's -Wuninitialized warnings are rarely false positives these days.

[1] http://gcc.gnu.org/ml/gcc/2013-07/msg00177.html
Attachment #8709148 - Flags: review?(khuey)
(Assignee)

Updated

2 years ago
Blocks: 925326
(Assignee)

Comment 2

2 years ago
Thanks!
status-firefox46: --- → fixed

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c6424d5ba522
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.