Closed Bug 1240592 Opened 4 years ago Closed 4 years ago

Remove unnecessary -Wno-uninitialized from dom/bindings

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Bug 831879 disabled -Wuninitialized warnings in dom/bindings. This is no longer necessary because the tree is now -Wuninitialized clean (bug 1001975).

gcc's -Wuninitialized historically had a well-deserved reputation for reporting false positives. In 2011 [1], gcc has separated -Wuninitialized's less reliable checks into a new -Wmaybe-uninitialized warning. gcc's and clang's -Wuninitialized warnings are rarely false positives these days.

[1] http://gcc.gnu.org/ml/gcc/2013-07/msg00177.html
Attachment #8709148 - Flags: review?(khuey)
Blocks: 925326
Thanks!
https://hg.mozilla.org/mozilla-central/rev/c6424d5ba522
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.