1240615 - Make PushService protocol init method return a Promise

Status: RESOLVED FIXED

(Core :: DOM: Push Notifications, defect)

Description

[Nick Alexander :nalexander [he/him]]

For Android GCM-based Push, it's possible for the set of known PushService registrations to change without Gecko being aware; and it's possible that Fennec can't initialize the GCM layer, so that DOM push should be unavailable.

This is not anticipated, but it can happen: for example, due to local device corruption; or due to the Google Play Services not being present on the device.

Therefore, when the PushService starts up, it should wait for the protocol to initialize successfully before finishing its own initialization.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1240615 - Make PushService protocol init method return a Promise. r?kitcambridge

I'd like to make `PushService.init` fallible, but it's not obvious how
to act on failure.  This patch at least allows each service to block
_startService until service-specific work initialization is complete.

Review commit: https://reviewboard.mozilla.org/r/31315/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31315/

Comment 2

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/projects/cedar/rev/e81adecdc007349bb9063ed65be5b32842bf439d
Bug 1240615 - Make PushService protocol init method return a Promise. r?kitcambridge

Comment 3

[Lina Cambridge [:lina] (ex-Mozilla)]

Comment on attachment 8709174 [details]
MozReview Request: Bug 1240615 - Make PushService protocol init method return a Promise. r?kitcambridge

https://reviewboard.mozilla.org/r/31315/#review28141

Thanks, Nick!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ffa2bb805aa

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ffa2bb805aa