Closed Bug 1240657 Opened 4 years ago Closed 4 years ago

[FasterMake] Race condition leads to missing "manifest interfaces.manifest" entries

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Turns out the claim in bug 1234439 that the FasterMake backend knows about all the chrome manifest entries is wrong, and there's still one that is added "manually" with buildlist.py, and during mach build faster, that can happen before or after the corresponding chrome manifests are written out by install manifest processing.
Turns out the claim in bug 1234439 that the FasterMake backend knows
about all the chrome manifest entries is wrong, and there's still one
that is added "manually" with buildlist.py, and during mach build
faster, that can happen before or after the corresponding chrome
manifests are written out by install manifest processing.

While the real fix here would be to make the build system totally
aware of those "manifest interfaces.manifest" entries, for now, it's
simpler to add dependencies to work around the race condition.
Attachment #8709264 - Flags: review?(gps)
Attachment #8709264 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/3c0a31d2f0e5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.