1240668 - Update GonkNativeHandle handling of gecko ipc

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

ParamTraits<GonkNativeHandle>::Write() mimics FenceHandle's implementation. But there is a difference of usages between GonkNativeHandle and FenceHandle. ParamTraits<GonkNativeHandle>::Write() needs updating a bit.

Comment 1

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> ParamTraits<GonkNativeHandle>::Write() mimics FenceHandle's implementation.
> But there is a difference of usages between GonkNativeHandle and
> FenceHandle. ParamTraits<GonkNativeHandle>::Write() needs updating a bit.

GonkNativeHandle be reused in current process.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Update ParamTraits<GonkNativeHandle>::Write()

Comment 3

[Sotaro Ikeda [:sotaro]]

attachment 8709309 [details] [diff] [review] is simple patch. But GonkNativeHandle::GetDupNhObj() might fail.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> attachment 8709309 [details] [diff] [review] is simple patch. But
> GonkNativeHandle::GetDupNhObj() might fail.

native_handle_create() could return nullptr.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Duplicate GonkNativeHandle::NhObj in ImageClientSingle::UpdateImage()

Comment 6

[Sotaro Ikeda [:sotaro]]

attachment 8709316 [details] [diff] [review] needs an explicit handling. It do not need to care about an error in Update ParamTraits<GonkNativeHandle>::Write().

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff2ffb04d032

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbbfbc2fb26a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dbbfbc2fb26a