Closed Bug 1240668 Opened 4 years ago Closed 4 years ago

Update GonkNativeHandle handling of gecko ipc

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file, 1 obsolete file)

ParamTraits<GonkNativeHandle>::Write() mimics FenceHandle's implementation. But there is a difference of usages between GonkNativeHandle and FenceHandle. ParamTraits<GonkNativeHandle>::Write() needs updating a bit.
Assignee: nobody → sotaro.ikeda.g
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> ParamTraits<GonkNativeHandle>::Write() mimics FenceHandle's implementation.
> But there is a difference of usages between GonkNativeHandle and
> FenceHandle. ParamTraits<GonkNativeHandle>::Write() needs updating a bit.

GonkNativeHandle be reused in current process.
Summary: Update ParamTraits<GonkNativeHandle>::Write() → Update GonkNativeHandle handling of gecko ipc
attachment 8709309 [details] [diff] [review] is simple patch. But GonkNativeHandle::GetDupNhObj() might fail.
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> attachment 8709309 [details] [diff] [review] is simple patch. But
> GonkNativeHandle::GetDupNhObj() might fail.

native_handle_create() could return nullptr.
attachment 8709316 [details] [diff] [review] needs an explicit handling. It do not need to care about an error in Update ParamTraits<GonkNativeHandle>::Write().
Attachment #8709316 - Attachment description: patch - Update ParamTraits<GonkNativeHandle>::Write() → patch - Update duplicate GonkNativeHandle::NhObj in ImageClientSingle::UpdateImage()
Attachment #8709316 - Attachment description: patch - Update duplicate GonkNativeHandle::NhObj in ImageClientSingle::UpdateImage() → patch - Duplicate GonkNativeHandle::NhObj in ImageClientSingle::UpdateImage()
Attachment #8709316 - Flags: review?(nical.bugzilla)
Attachment #8709316 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/dbbfbc2fb26a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.